[Agrifood Farming] Regenerate with latest codegen#20059
Merged
2 commits merged intoAzure:mainfrom Jan 27, 2022
joheredi:agrifood-regen
Merged
[Agrifood Farming] Regenerate with latest codegen#200592 commits merged intoAzure:mainfrom joheredi:agrifood-regen
2 commits merged intoAzure:mainfrom
joheredi:agrifood-regen
Conversation
joheredi
requested review from
bterlson,
jeremymeng,
ramya-rao-a and
xirzec
as code owners
ghost
added
the
Collaborator
|
API changes have been detected in |
sarangan12
approved these changes
Jan 26, 2022
Contributor
sarangan12
left a comment
sarangan12
left a comment
There was a problem hiding this comment.
Code changes look fine. But, I see some breaking changes. But there is no change in the version or package.json. Is this expected? Please confirm before merging
Member
Author
|
@sarangan12 we haven't released beta.2 so will keep it for the next release. Added a changelog entry |
|
Hello @joheredi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jan 28, 2022
**Checklists** - [x] Added impacted package name to the issue description **Packages impacted by this PR:** @azure-rest/agrifood-farming **Describe the problem that is addressed by this PR:** Re-generate Agrifood Farming using the latest version of RLC generator. This package was one of the first-ever RLCs generated and codegen has changes quite a bit since then. Regenerating against the same swagger. Major changes since last generation: - Switched away from @azure-rest/core-client-lro and @azure-rest/core-client-paging in favor of @azure/core-lro and @azure/core-client - Split Output and Input models **Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ NO **Are there test cases added in this PR?**_(If not, why?)_ NO, it already has tests **Provide a list of related PRs**_(if any)_ Azure#19897 **Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ `rushx generate:client`
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklists
Packages impacted by this PR:
@azure-rest/agrifood-farming
Describe the problem that is addressed by this PR:
Re-generate Agrifood Farming using the latest version of RLC generator. This package was one of the first-ever RLCs generated and codegen has changes quite a bit since then. Regenerating against the same swagger. Major changes since last generation:
Does this PR needs any fixes in the SDK Generator? (If so, create an Issue in the Autorest/typescript repository and link it here)
NO
Are there test cases added in this PR?(If not, why?)
NO, it already has tests
Provide a list of related PRs(if any)
#19897
Command used to generate this PR:(Applicable only to SDK release request PRs)
rushx generate:client