[Recorder] Rebrand recorder-new 1.0.0 as recorder 2.0.0 #19724
Conversation
ghost
added
the
customer-reported
|
Thank you for your contribution harsha-nalluru! We will review the pull request and get back to you soon. |
… harshan/recorder-v2
… harshan/recorder-v2
harsha-nalluru
requested review from
EmmaZhu,
HarshaNalluru,
XiaoningLiu,
deyaaeldeen,
jeremymeng,
jiacfan,
ljian3377,
mikeharder,
praveenkuttappan,
sadasant,
timovv,
vinjiang and
witemple-msft
as code owners
| - Existing recordings are played back as responses to the HTTP requests in the tests | ||
|
|
||
| Please refer to the [guidelines on Record and Playback](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/GUIDELINES.md) for more details. | ||
| Please refer to the [guidelines on Record and Playback](https://github.com/Azure/azure-sdk-for-js/blob/c06170fbaf39e81496f8009a0da93d470d8c9f88/sdk/test-utils/recorder/GUIDELINES.md) for more details. |
There was a problem hiding this comment.
Any reason to use a constant commit here?
There was a problem hiding this comment.
Thanks for the comment @EmmaZhu.
We are coming up with a new recorder based on the proxy tool built by the ENG SYS team.
Eventually, we'll be migrating all the services(tests) to use the new recorder.
Here's the migration guide - #19210
The guides are different for the old and new recorders.
Since storage is still on the old recorder, I'm pointing it to the docs that are relevant to the old recorder for storage.
Once storage packages are migrated to use the new proxy-tool based recorder, we'll update these links too.
|
Now that #18227 is in, we'll need to update the template to point to the rebranded package when this PR goes in. |
… harshan/recorder-v2
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
This reverts commit 3968440.
… harshan/recorder-v2
app.set('etag', false); // turn off
to avoid the if-none-match header
… harshan/recorder-v2
`docker image` = `"1294199"` `dotnet tool version` = `1.0.0-dev.20220113.1` These versions were tested at Azure/azure-sdk-for-js#19724. This PR will sync all 8 repos to get the newer proxy tool everywhere.
5 participants
Fixes #19743
Fixes #19858
Fixes #19860
What's going on?
@azure-tools/[email protected]with the unreleased changes (thanks to @praveenkuttappan 🙂)sdk/test-utils/recorderrecorder-new->recorder@azure-tools/[email protected]->@azure-tools/[email protected]