Update prettier dev-dependency to v2.5.1 in Tables#19579
Merged
JonathanCrd merged 2 commits intoAzure:mainfrom Jan 3, 2022
Merged
Update prettier dev-dependency to v2.5.1 in Tables#19579JonathanCrd merged 2 commits intoAzure:mainfrom
JonathanCrd merged 2 commits intoAzure:mainfrom
Conversation
ghost
added
the
JonathanCrd
requested review from
deyaaeldeen,
joheredi,
mikeharder,
praveenkuttappan and
witemple-msft
as code owners
joheredi
approved these changes
Jan 3, 2022
Member
joheredi
left a comment
joheredi
left a comment
There was a problem hiding this comment.
LGTM! Thanks for sending this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves: #9329 for packages under
sdk/tables.Updated
prettierdev-dependency version to latest2.5.1.Files were re-formatted as well. There are only format changes in this PR, no manual changes except for upgrading the prettier version inside package.json files.
Another manual change was removing the path
\"src/**/*.ts\"from bothformatandcheck-formatscripts in projects inside perf-tests. This is because the perf-tests do not contain a src/ folder and that makes the scripts fail with an exit code 2.Main format changes with Prettier 2.x in this PR include:
functionkeyword.