[Unified Recorder] Updates the dev-tool commands to follow the new syntax#19419
Merged
HarshaNalluru merged 17 commits intoAzure:mainfrom Dec 17, 2021
Merged
Conversation
ghost
added
the
HarshaNalluru
changed the title
HarshaNalluru
requested review from
deyaaeldeen,
jeremymeng,
sadasant,
timovv and
witemple-msft
HarshaNalluru
requested review from
mikeharder and
praveenkuttappan
as code owners
jeremymeng
approved these changes
Dec 17, 2021
Member
jeremymeng
left a comment
jeremymeng
left a comment
There was a problem hiding this comment.
Look better without the escaped quote! Some minor styling comments.
Co-authored-by: Jeremy Meng <yumeng@microsoft.com>
Co-authored-by: Jeremy Meng <yumeng@microsoft.com>
Co-authored-by: Jeremy Meng <yumeng@microsoft.com>
Member
witemple-msft
left a comment
witemple-msft
left a comment
There was a problem hiding this comment.
Have the scripts already been changed to actually use the ["--"] args at runtime?
Co-authored-by: Will Temple <witemple@microsoft.com>
Co-authored-by: Will Temple <witemple@microsoft.com>
Co-authored-by: Will Temple <witemple@microsoft.com>
Contributor
Author
Great catch! @witemple-msft |
… harshan/issue/recorder-19094
…shaNalluru/azure-sdk-for-js into harshan/issue/recorder-19094
Contributor
Author
|
Moving to draft since "--" still needs some work. |
… harshan/issue/recorder-19094
witemple-msft
approved these changes
Dec 17, 2021
5 tasks
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Jun 15, 2022
TestBase 2022-04-01-preview (from RPaaSMaster) (Azure#19419) * copy 2022-04-01-preview from rpaasmaster * sdk md file change * modify subscription id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19094
Moving to the new syntax that works in both windows and linux.
TODO