Skip to content

Update nyc to v15#19248

Merged
6 commits merged intoAzure:mainfrom
ramya-rao-a:nyc
Dec 13, 2021
Merged

Update nyc to v15#19248
6 commits merged intoAzure:mainfrom
ramya-rao-a:nyc

Conversation

@ramya-rao-a
Copy link
Copy Markdown
Contributor

@ramya-rao-a ramya-rao-a commented Dec 11, 2021 •
edited
Loading

This PR makes the following updates regarding the nyc dependency

  • Update to v15 from v14 across all packages
  • Updates to @azure/monitor-opentelemetry-exporter as it failed to run the tests with the updated nyc.
    • Update the test scripts to use the js files in the dist-esm folder like all other packages instead of using the ts-node plugin.
    • Update one of the tests for @azure/monitor-opentelemetry-exporter to use the right path for package.json file now that the tests are being run from the dist-esm folder.

Random set of live tests were triggered from this PR to ensure that nyc works as expected.
The failure for data-tables is an unrelated service side issue

Resolves #19232

@ghost ghost added the KeyVault label Dec 11, 2021
@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 11, 2021

/azp run js - keyvault-keys - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 11, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a ramya-rao-a changed the title Update nyc for keyvault-keys Update nyc to v15 Dec 11, 2021
@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 11, 2021

/azp run js - ai-text-analytics - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 11, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 11, 2021

/azp run js - attestation - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 11, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 11, 2021

/azp run js - communication-chat - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 11, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 11, 2021

/azp run js - container-registry - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 11, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 11, 2021

/azp run js - data-tables - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 11, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 11, 2021

/azp run js - identity - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 11, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 12, 2021

/azp run js - eventgrid - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 12, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 12, 2021

/azp run js - keyvault-keys - tests

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 12, 2021

/azp run js - keyvault-secrets - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 12, 2021

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 12, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 12, 2021

/azp run js - keyvault-secrets - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 12, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 12, 2021

/azp run js - mixed-reality-authentication - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 12, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

ramya-rao-a commented Dec 12, 2021

/azp run js - search-documents - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 12, 2021

Azure Pipelines successfully started running 1 pipeline(s).

sarangan12
sarangan12 approved these changes Dec 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sarangan12 sarangan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

search-documents SDK changes look fine.

sadasant
sadasant approved these changes Dec 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

ellismg
ellismg approved these changes Dec 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventgrid changes look good. Thank you for doing this, @ramya-rao-a!

@HarshaNalluru
Copy link
Copy Markdown
Contributor

HarshaNalluru commented Dec 13, 2021

Looks like the formatting is failing.

@ghost
Copy link
Copy Markdown

ghost commented Dec 13, 2021

Hello @ramya-rao-a!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6c12ef4 into Azure:main Dec 13, 2021
@ramya-rao-a ramya-rao-a deleted the nyc branch December 13, 2021 23:51
@ramya-rao-a ramya-rao-a mentioned this pull request Dec 13, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlonsoMondal AlonsoMondal Awaiting requested review from AlonsoMondal

@arifibrahim4 arifibrahim4 Awaiting requested review from arifibrahim4

@AriZavala2 AriZavala2 Awaiting requested review from AriZavala2

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@bterlson bterlson Awaiting requested review from bterlson

@craigktreasure craigktreasure Awaiting requested review from craigktreasure

@danielav7 danielav7 Awaiting requested review from danielav7

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen is a code owner

@EmmaZhu EmmaZhu Awaiting requested review from EmmaZhu EmmaZhu is a code owner

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg hectorhdzg is a code owner

@hivyas hivyas Awaiting requested review from hivyas

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

@jiacfan jiacfan Awaiting requested review from jiacfan jiacfan is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner

@LarryOsterman LarryOsterman Awaiting requested review from LarryOsterman

@ljian3377 ljian3377 Awaiting requested review from ljian3377 ljian3377 is a code owner

@LuChen-Microsoft LuChen-Microsoft Awaiting requested review from LuChen-Microsoft LuChen-Microsoft is a code owner

@matyrr-havok matyrr-havok Awaiting requested review from matyrr-havok

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner

@miguhern miguhern Awaiting requested review from miguhern

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@nguerrera nguerrera Awaiting requested review from nguerrera

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft

@RoyHerrod RoyHerrod Awaiting requested review from RoyHerrod

@schaabs schaabs Awaiting requested review from schaabs

@vicancy vicancy Awaiting requested review from vicancy vicancy is a code owner

@vinjiang vinjiang Awaiting requested review from vinjiang vinjiang is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@whisper6284 whisper6284 Awaiting requested review from whisper6284

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

@XiaoningLiu XiaoningLiu Awaiting requested review from XiaoningLiu XiaoningLiu is a code owner

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

@YoDaMa YoDaMa Awaiting requested review from YoDaMa

4 more reviewers

@sadasant sadasant sadasant approved these changes

@sarangan12 sarangan12 sarangan12 approved these changes

@ellismg ellismg ellismg approved these changes

@HarshaNalluru HarshaNalluru HarshaNalluru approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dependency package nyc has a new version available

5 participants

@ramya-rao-a @HarshaNalluru @sadasant @sarangan12 @ellismg