[service-bus / eventhubs] - Fix browser tests#19244
Merged
maorleger merged 4 commits intoAzure:mainfrom Dec 12, 2021
Merged
Conversation
ghost
added
the
Member
Author
|
/azp run js - service-bus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maorleger
requested review from
HarshaNalluru,
deyaaeldeen,
jeremymeng,
ramya-rao-a and
richardpark-msft
as code owners
maorleger
changed the title
Member
Author
|
/azp run js - event-hubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeremymeng
approved these changes
Dec 11, 2021
deyaaeldeen
approved these changes
Dec 11, 2021
Member
Author
|
/azp run js - service-bus - tests |
Member
Author
|
/azp run js - event-hubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
maorleger
force-pushed
the
fix-servicebus-rollup
branch
from
a67476c to
6fc3bdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
assertwithchaiWhy
Ok, we tried! We tried to use the shared rollup config across packages but unfortunately service-bus event-hubs are and will likely remain a special case due to the various dependencies it pulls in. We identified a few fixable issues but there are some
that will not be easily resolved.
So, working with Will we decided a reasonable compromise is to use the shared config but patch the plugins so that they
match what they were before the recent changes.
In passing, I am also removing any imports of the
assertmodule as that has been removed and the tests are failing. So thisshould fix that as well.