Skip to content

[AutoPR storage/resource-manager] SRP Apr19 API supporting automatic snapshot feature#1917

Closed
AutorestCI wants to merge 1 commit intorestapi_auto_storage/resource-managerfrom
restapi_auto_5522
Closed

[AutoPR storage/resource-manager] SRP Apr19 API supporting automatic snapshot feature#1917
AutorestCI wants to merge 1 commit intorestapi_auto_storage/resource-managerfrom
restapi_auto_5522

Conversation

@AutorestCI
Copy link
Contributor

@kpajdzik kpajdzik closed this Apr 2, 2019
@kpajdzik kpajdzik deleted the restapi_auto_5522 branch April 2, 2019 15:44
azure-sdk pushed a commit that referenced this pull request Aug 18, 2021
azure-sdk added a commit that referenced this pull request Aug 18, 2021
* Attempt to purge all vaults, managed HSMs

Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.

* Add timeout and more logging

* Pass required -Resource

* Fix log message

* Ensure the $Resource is correctly captured

Added comment to new code explaining why, since ScriptBlock.GetNewClosure() is not working as expected.

* Add -ErrorAction to Receive-Job

Worked without terminating when run locally, but failed on the first error in the AzDO agent.

* Use $using:r instead of creating ScriptBlock

More idiomatic for passing ScriptBlocks to jobs.

* Resolve PR feedback

* Change default DeleteAfterHours to 120

Resolves #1917

* Use the Az cmdlets built-in -AsJob

Co-authored-by: Heath Stewart <heaths@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments