Skip to content

Avoid pointing to docs that are misleading about API deprecation #19081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramya-rao-a merged 1 commit into from
Dec 10, 2021
Merged

Avoid pointing to docs that are misleading about API deprecation #19081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ export class ServiceBusAdministrationClient extends ServiceClient {
* All queue properties must be set even though only a subset of them are actually updatable.
* Therefore, the suggested flow is to use the output from `getQueue()`, update the desired properties in it, and then pass the modified object to `updateQueue()`.
*
* See https://docs.microsoft.com/rest/api/servicebus/update-queue for more details.
* The properties that cannot be updated are marked as readonly in the `QueueProperties` interface.
*
* @param queue - Object representing the properties of the queue and the raw response.
* `requiresSession`, `requiresDuplicateDetection`, `enablePartitioning`, and `name` can't be updated after creating the queue.
Expand Down Expand Up @@ -1127,7 +1127,7 @@ export class ServiceBusAdministrationClient extends ServiceClient {
* All topic properties must be set even though only a subset of them are actually updatable.
* Therefore, the suggested flow is to use the output from `getTopic()`, update the desired properties in it, and then pass the modified object to `updateTopic()`.
*
* See https://docs.microsoft.com/rest/api/servicebus/update-topic for more details.
* The properties that cannot be updated are marked as readonly in the `TopicProperties` interface.
*
* @param topic - Object representing the properties of the topic and the raw response.
* `requiresDuplicateDetection`, `enablePartitioning`, and `name` can't be updated after creating the topic.
Expand Down Expand Up @@ -1642,6 +1642,7 @@ export class ServiceBusAdministrationClient extends ServiceClient {
* All subscription properties must be set even though only a subset of them are actually updatable.
* Therefore, the suggested flow is to use the output from `getSubscription()`, update the desired properties in it, and then pass the modified object to `updateSubscription()`.
*
* The properties that cannot be updated are marked as readonly in the `SubscriptionProperties` interface.
* @param subscription - Object representing the properties of the subscription and the raw response.
* `subscriptionName`, `topicName`, and `requiresSession` can't be updated after creating the subscription.
* @param operationOptions - The options that can be used to abort, trace and control other configurations on the HTTP request.
Expand Down