Skip to content

Update AzureIdentityExamples.md#18958

Merged
sadasant merged 1 commit intoAzure:masterfrom
philip-gai:patch-3
Dec 7, 2021
Merged

Update AzureIdentityExamples.md#18958
sadasant merged 1 commit intoAzure:masterfrom
philip-gai:patch-3

Conversation

@philip-gai
Copy link
Copy Markdown
Contributor

Rename function to match the credential being used

Rename function to match the credential being used
Copy link
Copy Markdown
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@ghost
Copy link
Copy Markdown

ghost commented Dec 6, 2021

Hello @sadasant!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@check-enforcer
Copy link
Copy Markdown

check-enforcer bot commented Dec 6, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@sadasant
Copy link
Copy Markdown
Contributor

sadasant commented Dec 6, 2021

/check-enforcer evaluate

@sadasant
Copy link
Copy Markdown
Contributor

sadasant commented Dec 7, 2021

/check-enforcer override

@sadasant sadasant merged commit d4428c6 into Azure:master Dec 7, 2021
@philip-gai philip-gai deleted the patch-3 branch December 7, 2021 05:09
@sadasant
Copy link
Copy Markdown
Contributor

Sorry @philip-gai , turns out this PR was against master, but we had moved to main some months ago. The master branch you targeted was created by mistake after we migrated to main. I’ll need to do this change on main through another PR.

@philip-gai
Copy link
Copy Markdown
Contributor Author

@sadasant Shoot! Thanks for letting me know. Do you want me to create the new PR? I'd be happy to do so.

HarshaNalluru added a commit that referenced this pull request Dec 17, 2021
* Fix retry handling for Session Not Found errors

* Update sdk/cosmosdb/cosmos/test/internal/session.spec.ts

Co-authored-by: Zachary Foster <zfoster@users.noreply.github.com>

* Update CODEOWNERS for Application Insights (#17055)

* Add link to documentation (#18291)

* Update AzureIdentityExamples.md (#18958)

Rename function to match the credential being used

* new package for test credential

* revert unrelated changes

* unrelated changes

* lock file

* Update sdk/test-utils/identity-extensions/CHANGELOG.md

* Update sdk/test-utils/identity-extensions/CHANGELOG.md

* Update sdk/test-utils/identity-extensions/package.json

* Update sdk/test-utils/identity-extensions/package.json

* Move NoOpCredential to identity extensions package

* Update sdk/test-utils/identity-extensions/README.md

Co-authored-by: Will Temple <witemple@microsoft.com>

* Update sdk/test-utils/identity-extensions/README.md

Co-authored-by: Will Temple <witemple@microsoft.com>

* Update sdk/test-utils/identity-extensions/README.md

Co-authored-by: Will Temple <witemple@microsoft.com>

* Update sdk/test-utils/identity-extensions/README.md

Co-authored-by: Will Temple <witemple@microsoft.com>

* Update sdk/test-utils/identity-extensions/src/index.ts

Co-authored-by: Will Temple <witemple@microsoft.com>

* renames

* changelog

* more updates

* ysage in readme

* unused in package.json

* TokenCredentialOptions optional

Co-authored-by: Steve Faulkner <southpolesteve@gmail.com>
Co-authored-by: Zachary Foster <zfoster@users.noreply.github.com>
Co-authored-by: omziv <80668253+omziv@users.noreply.github.com>
Co-authored-by: Dina Berry <41597107+diberry@users.noreply.github.com>
Co-authored-by: Philip Gai <philip-gai@github.com>
Co-authored-by: Will Temple <witemple@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants