Skip to content

[sort-imports] update keyvault-secrets with respect to sort-imports rule#18952

Closed
bzhang0 wants to merge 1 commit intoAzure:mainfrom
bzhang0:sort-imports--keyvault-secrets
Closed

[sort-imports] update keyvault-secrets with respect to sort-imports rule#18952
bzhang0 wants to merge 1 commit intoAzure:mainfrom
bzhang0:sort-imports--keyvault-secrets

Conversation

@bzhang0
Copy link
Copy Markdown
Contributor

@bzhang0 bzhang0 commented Dec 5, 2021

This PR is working in conjunction with other PRs to solve #9252.
As per my previous PR #18598, I will be making multiple PRs to fix individual sections of the azure codebase with respect to the new sort-imports rule.

In this PR, I have fixed all files under sdk/keyvault/keyvault-secrets.

@ghost ghost added KeyVault customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 5, 2021
@ghost
Copy link
Copy Markdown

ghost commented Dec 5, 2021

Thank you for your contribution bzhang0! We will review the pull request and get back to you soon.

@ghost ghost added the Impact++ This pull request was submitted by a member of the Impact++ team. label Dec 5, 2021
@ghost
Copy link
Copy Markdown

ghost commented Dec 5, 2021

Thank you for your contribution, bzhang0!

@bzhang0
Copy link
Copy Markdown
Contributor Author

bzhang0 commented Dec 5, 2021

It seems I'm getting a lot of failed checks, which is likely due to some conflicts when I called git cherry-pick. I will revert back to a stable version and manually fix linter errors to avoid this.

@bzhang0
Copy link
Copy Markdown
Contributor Author

bzhang0 commented Dec 6, 2021

I will be closing this as well. It seems that running rush build is inconsistent in terms of build errors. I ensured that the build ran properly before adjusting only the sort-imports warnings, but rush build still returns an error after doing this. I'll probably try doing different directories first, and making sure this error isn't for all parts of the repository.

@bzhang0 bzhang0 closed this Dec 6, 2021
@bzhang0 bzhang0 deleted the sort-imports--keyvault-secrets branch December 6, 2021 03:34
@bzhang0 bzhang0 restored the sort-imports--keyvault-secrets branch December 8, 2021 08:46
@bzhang0 bzhang0 deleted the sort-imports--keyvault-secrets branch December 8, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization. Impact++ This pull request was submitted by a member of the Impact++ team. KeyVault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants