Skip to content

[Unified Recorder] Add sample unified recorder tests to template #18817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timovv merged 26 commits into from
Jan 10, 2022
Merged

[Unified Recorder] Add sample unified recorder tests to template #18817

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
5fe93bd
Add sample unified recorder tests to template
timovv Nov 24, 2021
d52f4cf
Fix lint issues
timovv Nov 30, 2021
eee8f21
Fix tests to work in browser
timovv Dec 6, 2021
a806c32
Provide environment variable export
timovv Dec 9, 2021
bf68caa
Make the new recorder use its own env export
timovv Dec 9, 2021
e1b9139
Fix up the tests a little bit
timovv Dec 9, 2021
ff90778
WIP -- trying to fix browser tests
timovv Dec 10, 2021
bf61f75
load the env file by default
HarshaNalluru Dec 10, 2021
a774935
changelog
HarshaNalluru Dec 10, 2021
368e8b5
Merge branch 'harshan/load-env-by-default' of https://github.com/Hars…
HarshaNalluru Dec 10, 2021
b2a88fb
fix template project
HarshaNalluru Dec 10, 2021
52e3d69
Update sdk/test-utils/recorder-new/test/testProxyTests.spec.ts
HarshaNalluru Dec 10, 2021
9a05a69
Update sdk/test-utils/recorder-new/test/testProxyTests.spec.ts
HarshaNalluru Dec 10, 2021
0ae9935
revert testing things
timovv Dec 10, 2021
8925380
Merge branch 'main' into unified-recorder/18227-unified-recorder-in-t…
timovv Dec 10, 2021
04ea007
Revert accidental changes to testing-recorder-new recordings
timovv Dec 14, 2021
a3fb7cf
Remove the storage-queue/data-tables tests
timovv Dec 15, 2021
6676616
Remove recordings we don't need any more
timovv Dec 15, 2021
4217995
Merge branch 'main' into unified-recorder/18227-unified-recorder-in-t…
timovv Dec 15, 2021
76c7bab
Merge branch 'main' into unified-recorder/18227-unified-recorder-in-t…
timovv Dec 16, 2021
88f8624
Merge branch 'main' into unified-recorder/18227-unified-recorder-in-t…
timovv Dec 21, 2021
52ab72b
Updates to template based on new refactor
timovv Dec 21, 2021
9239f0d
New syntax for dev-tool run
timovv Dec 22, 2021
ffe8cd9
Merge branch 'main' into unified-recorder/18227-unified-recorder-in-t…
timovv Jan 4, 2022
c30f419
Formatting
timovv Jan 4, 2022
b089f40
Merge branch 'main' into unified-recorder/18227-unified-recorder-in-t…
timovv Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/template/template/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

// https://github.com/karma-runner/karma-chrome-launcher
process.env.CHROME_BIN = require("puppeteer").executablePath();
process.env.RECORDINGS_RELATIVE_PATH = require("@azure-tools/test-recorder-new").relativeRecordingsPath();
require("dotenv").config();
const {
jsonRecordingFilterFunction,
Expand Down Expand Up @@ -60,7 +61,8 @@ module.exports = function(config) {
"APPCONFIG_TEST_SETTING_EXPECTED_VALUE",
"AZURE_CLIENT_ID",
"AZURE_CLIENT_SECRET",
"AZURE_TENANT_ID"
"AZURE_TENANT_ID",
"RECORDINGS_RELATIVE_PATH"
],

// test results reporter to use
Expand Down
15 changes: 8 additions & 7 deletions sdk/template/template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,17 @@
"extract-api": "tsc -p . && api-extractor run --local",
"format": "prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
"generate:client": "autorest --typescript ./swagger/README.md",
"integration-test:browser": "karma start --single-run",
"integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 5000000 --full-trace \"dist-esm/test/{,!(browser)/**/}/*.spec.js\"",
"integration-test:browser": "dev-tool run test:browser",

@joheredi joheredi Dec 17, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev-tool run test:browser is a different script than the test:browser in line 48 right? Not a big deal but I was originally confused thinking this would end up in an infinite loop of "test:browser" -> "integration-test:browser" -> "test:browser".

I wonder if we can have a different name in dev-tool?

"integration-test:node": "dev-tool run test:node-ts-input --mocha=\"--timeout 1200000 'test/**/*.spec.ts'\"",
Comment thread
timovv marked this conversation as resolved.
Outdated
"integration-test": "npm run integration-test:node && npm run integration-test:browser",
"lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]",
"lint": "eslint package.json api-extractor.json src test --ext .ts",
"pack": "npm pack 2>&1",
"test:browser": "npm run clean && npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
"test:node": "npm run clean && tsc -p . && npm run unit-test:node && npm run integration-test:node",
"test:browser": "npm run clean && npm run build:test && npm run integration-test:browser",
"test:node": "npm run clean && tsc -p . && npm run integration-test:node",
"test": "npm run clean && tsc -p . && npm run unit-test:node && rollup -c 2>&1 && npm run unit-test:browser && npm run integration-test",
"unit-test:browser": "karma start --single-run",
"unit-test:node": "mocha -r esm -r ts-node/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 1200000 --full-trace --exclude \"test/**/browser/*.spec.ts\" \"test/**/*.spec.ts\"",
"unit-test:browser": "npm run integration-test:browser",
"unit-test:node": "npm run integration-test:node",
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
},
"files": [
Expand Down Expand Up @@ -123,7 +123,8 @@
"source-map-support": "^0.5.9",
"typedoc": "0.15.2",
"typescript": "~4.2.0",
"util": "^0.12.1"
"util": "^0.12.1",
"@azure-tools/test-recorder-new": "~1.0.0"
},
"//sampleConfiguration": {
"skipFolder": false,
Expand Down
96 changes: 47 additions & 49 deletions ...figurationclient_functional_tests/recording_predetermined_setting_has_expected_value.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 42 additions & 0 deletions ...gs/browsers/core_v1_tests_using_unified_recorder/recording_storagequeue_create_queue.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

143 changes: 143 additions & 0 deletions ...ngs/browsers/core_v2_tests_using_unified_recorder/recording_datatables_create_entity.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading