Add better logging to GetExistingPackageVersions#18704
Merged
chidozieononiwu merged 1 commit intoAzure:mainfrom Nov 17, 2021
Merged
Add better logging to GetExistingPackageVersions#18704chidozieononiwu merged 1 commit intoAzure:mainfrom
chidozieononiwu merged 1 commit intoAzure:mainfrom
Conversation
chidozieononiwu
requested review from
danieljurek,
mikeharder,
praveenkuttappan and
weshaggard
as code owners
chidozieononiwu
force-pushed
the
UpdateLangSettings
branch
from
f5c1471 to
6d08e36
Compare
weshaggard
reviewed
Nov 16, 2021
chidozieononiwu
force-pushed
the
UpdateLangSettings
branch
from
6d08e36 to
63e28d3
Compare
weshaggard
reviewed
Nov 16, 2021
Member
There was a problem hiding this comment.
Do we even want this to be warning given that this is an expected state?
Member
Author
There was a problem hiding this comment.
Ok, I see. So only error for exceptions that are not 404
chidozieononiwu
force-pushed
the
UpdateLangSettings
branch
from
63e28d3 to
9e57518
Compare
weshaggard
approved these changes
Nov 16, 2021
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Please be sure that you tested this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve logging.