Skip to content

fix reinstall native dependency #18582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Praveen Kuttappan (praveenkuttappan) merged 11 commits into from
Nov 9, 2021
Merged

fix reinstall native dependency #18582

Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7988bf4
DEbug keytar install
praveenkuttappan Nov 8, 2021
c67c05f
DEbug keytar install
praveenkuttappan Nov 8, 2021
e1b561c
DEbug keytar install
praveenkuttappan Nov 9, 2021
3093d46
More debugging
praveenkuttappan Nov 9, 2021
3d02807
More debugging with possible solution
praveenkuttappan Nov 9, 2021
cea3550
Generate absolute path for symlink to reinstall native dependency
praveenkuttappan Nov 9, 2021
87be2ae
Additional fix
praveenkuttappan Nov 9, 2021
cfa3410
Additional fix
praveenkuttappan Nov 9, 2021
4e8fcd2
Add step condition and remvoe empty line
praveenkuttappan Nov 9, 2021
b07de39
Changes as per review comments
praveenkuttappan Nov 9, 2021
41d05b1
More review changes
praveenkuttappan Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eng/pipelines/templates/steps/use-node-test-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ steps:
}
# Map from the symlink path to the target path (npm has issues installing into symlink dirs)
# Example: common/temp/node_modules/.pnpm/keytar@5.6.0/node_modules/keytar
$targetPath = (Get-Item $symlink).Target
$symlinkInfo = Get-Item $symlink
$targetPath = [IO.Path]::Combine($symlinkInfo.Parent, $symlinkInfo.Target)
Write-Host "Target of symlink : $($targetPath)"

# Need to run "npm install" at path containing "node_modules" folder
# Example: common/temp/node_modules/.pnpm/keytar@5.6.0
Expand All @@ -38,11 +40,9 @@ steps:
}

$packageAtVersion = Split-Path -Leaf $packageInstallPath

Comment thread
praveenkuttappan marked this conversation as resolved.
# pnpm v6 replaces '/' in package names with '+' to reduce nesting directory in virtual store so we need to
# change it back
$packageAtVersion = $packageAtVersion.Replace("+", "/")

@praveenkuttappan Praveen Kuttappan (praveenkuttappan) Nov 9, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted this new line change and it's showing up correctly on view file of latest commit.

# Check if package has org name. for e.g @azure/msal-node-enxtensions
# This returns either @azure or .pnpm( if no org is present)
$packageParentName = Split-path -Leaf (Split-Path -Parent -Resolve $packageInstallPath)
Expand All @@ -62,4 +62,4 @@ steps:
}

displayName: Reinstall native dependencies
condition: ne(variables['NodeTestVersion'], variables['NodeVersion'])
Comment thread
praveenkuttappan marked this conversation as resolved.
condition: and(succeeded(),ne(variables['NodeTestVersion'], variables['NodeVersion']))