Merged
Conversation
sima-zhu
requested review from
mikeharder,
praveenkuttappan and
weshaggard
as code owners
weshaggard
approved these changes
Nov 8, 2021
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
I'm fine with this in the short-term but we should figure out if we need this increase long-term after you better understand what is taking longer than expected.
Contributor
Author
We have two places running docker validation nightly. One is main branch, one is daily branch. The one in our test is only touching daily branch. For schedule run, we double the time by running on main branch. Even checking whether package exist or not will not help too much, as we have different versions between main and daily branches. |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 11, 2022
Swagger correctness: Fix readonly properties & add additional cluster witness properties (Azure#18573)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docindex pipeline failed at 60 min limitation.
Extend the timeout for short term solution.
For long term run, will try to install only non-existing packages.