Merged
Conversation
colawwj
requested review from
bterlson,
deyaaeldeen,
jeremymeng,
mikeharder,
praveenkuttappan,
ramya-rao-a,
witemple-msft and
xirzec
as code owners
ramya-rao-a
reviewed
Nov 9, 2021
eng/ignore-links.txt
Outdated
| https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/quota/arm-extendedlocation | ||
| https://docs.microsoft.com/javascript/api/@azure/arm-videoanalyzer | ||
| https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/videoanalyzer/arm-videoanalyzer | ||
| <<<<<<< HEAD |
Contributor
There was a problem hiding this comment.
Please resolve the merge conflict here
Member
There was a problem hiding this comment.
Also we should try to avoid adding anything to this ignore-links file.
ramya-rao-a
reviewed
Nov 9, 2021
| "rollup-plugin-sourcemaps": "^0.4.2", | ||
| "typescript": "~4.2.0", | ||
| "uglify-js": "^3.4.9", | ||
| "@azure/identity": "2.0.0-beta.6", |
Contributor
There was a problem hiding this comment.
Please use ^2.0.1 instead of 2.0.0-beta.6 here
Member
There was a problem hiding this comment.
@sarangan12 Could you help review this PR Azure/autorest.typescript#1233 ASAP so that cases like this won't happen again. Thanks
Member
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run js - desktopvirtualization - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiaozha
approved these changes
Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relesae for issue: https://github.com/Azure/sdk-release-request/issues/2184