TestProxy with a switch to start

[HarshaNalluru]

Doing similar to what has been done in GO.

[check-enforcer]

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

[scbedd]

down below we call into ci.yml. We need to add additional parameter so the call looks like this:

      - template: /eng/pipelines/templates/jobs/ci.yml
        parameters:
          ServiceDirectory: ${{ parameters.ServiceDirectory }}
          TestProxy: ${{ parameterse.TestProxy }}
          Artifacts: ${{ parameters.Artifacts }}

[scbedd]

Parameters are compile-time constants. So technically it'll work if we miss adding it to each level of templates, but it'll be super confusing to debug. Better to pass all the way through.

[scbedd]

IN jobs/ci.yml, we need to add the parameter (and then pass it to ci.tests.yml -> tests.yml)

[HarshaNalluru]

Does it look good now?

[scbedd]

Yes! At least, I think so :)

[praveenkuttappan]

you are not passing this parameter ci.yml. We need to pass this parameter down to test.yml template. Here ci.yml

and https://github.com/Azure/azure-sdk-for-js/blob/main/eng/pipelines/templates/jobs/ci.yml#L78

and https://github.com/Azure/azure-sdk-for-js/blob/main/eng/pipelines/templates/jobs/ci.tests.yml#L54

[HarshaNalluru]

Does it look good now?

[scbedd]

yeah. seems reasonable. now let's see what breaks 👍

[HarshaNalluru]

Yayy! Running fine. 🎉
@scbedd @praveenkuttappan

[HarshaNalluru]

Suggested change

	- ${{ if eq(parameters.TestProxy, true) }}:
	- pwsh: |
	# ambitious_azsdk_test_proxy is the hardcoded container name used
	# by the test proxy startup script
	docker logs ambitious_azsdk_test_proxy
	displayName: 'Dump Test Proxy logs'
	condition: succeededOrFailed()

Also removing this @scbedd

Do you have an alternative for this?

[scbedd]

I will. issue filed

[scbedd]

And PR