cosmosdb-track2#17739
Conversation
colawwj
requested review from
deyaaeldeen,
dw511214992,
qiaozha and
witemple-msft
as code owners
ghost
added
the
colawwj
requested review from
mikeharder and
praveenkuttappan
as code owners
| extends: | ||
| template: ../../eng/pipelines/templates/stages/cosmos-sdk-client.yml #NOTE: Non-standard template. | ||
| template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml |
There was a problem hiding this comment.
@praveenkuttappan @ramya-rao-a Do you have any idea why cosmosdb is using a different template here ? Is it okay to change it into archetype-sdk-client.yml and enable the unit tests now?
There was a problem hiding this comment.
I remember cosmos config is different from other packages. It needs to setup the emulator to run tests. @HarshaNalluru may also have more info.
There was a problem hiding this comment.
Yes, cosmos sdk uses the emulator instead of the live service for testing, and hence different template.
There was a problem hiding this comment.
We will need two different pipeline under cosmos service in that case with different artifact set and triggering path.
- One for cosmos package using emulator
- another one for mgmt package.
I do not prefer that option unless we have no other choice. why does cosmos mgmt needs different type of testing? Is it because it doesn't need emulator at all?
There was a problem hiding this comment.
@praveenkuttappan any updates to this cosmosdb ci template issue ?
There was a problem hiding this comment.
I have submitted PR #18659 to add new pipeline for cosmos mgmt package.
There was a problem hiding this comment.
and this has created pipeline https://dev.azure.com/azure-sdk/public/_build?definitionId=3311
Add x-ms-identifiers for datacatalog (Azure#17739)
6 participants
No description provided.