[Schema Registry] Remove caching#17732
Merged
deyaaeldeen merged 6 commits intoAzure:mainfrom Sep 24, 2021
Merged
Conversation
deyaaeldeen
requested review from
JoshLove-msft,
conniey,
ramya-rao-a,
swathipil and
yunhaoling
JoshLove-msft
approved these changes
Sep 18, 2021
nguerrera
approved these changes
Sep 20, 2021
deyaaeldeen
force-pushed
the
schema-registry/remove-cache
branch
from
6086048 to
5019546
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback from the archboard in #17697 and Azure/azure-sdk#3293.
The idea is to ask customers to rely on caching in the
@azure/schema-registry-avropackage instead. Also, since@azure/schema-registry-avrotakes a client as input that implements an interface that matches that of@azure/schema-registryclient class, the customer can write their own caching layer around the class and pass that object as the client to the serializer if they need to.