Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1902 See eng/common workflow

- Fix rg.Name to rg.ResourceGroupName
- Add more verbose logging for better debugging
- Handle deleted resource groups when gathering puragable resource
- Remove coerce now that we are collecting in functions
@azure-sdk azure-sdk added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Aug 13, 2021
@weshaggard weshaggard merged commit 628bcc6 into main Aug 13, 2021
@weshaggard weshaggard deleted the sync-eng/common-FixResourceCleanup-1902 branch August 13, 2021 22:33
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Dec 29, 2021
S360 - Swagger Correctness - Microsoft.ResourceHealth (Azure#16920)

* Update ResourceHealth.json

fixed s360

* Update AvailabilityStatus_GetByResource.json

s360

* Update AvailabilityStatuses_List.json

s360

* Update AvailabilityStatuses_ListByResourceGroup.json

s360

* Update AvailabilityStatuses_ListByResourceGroup.json

s360

* Update AvailabilityStatuses_ListBySubscriptionId.json

s360

* Update AvailabilityStatus_GetByResource.json

s360

* Update AvailabilityStatuses_List.json

s360

* Update AvailabilityStatuses_ListByResourceGroup.json

s360

* Update AvailabilityStatuses_ListByResourceGroup.json

s360

* Update AvailabilityStatuses_ListBySubscriptionId.json

s360

* Update ResourceHealth.json

s360

* Update ResourceHealth.json

removing the "title" change in Line 370 - see if checks will be good

* Prettie changes

* Update ResourceHealth.json

fixing PR check Operations_List

* Update ResourceHealth.json

fixing PR checks

* Update ResourceHealth.json

fix PR checks 9:06AM

* Update ResourceHealth.json

fix PR checks

* Update ResourceHealth.json

fixed spaces

* Update ResourceHealth.json

fixed ResourceHealth.json

* Create Operations_List.json

fixed PR checks

* Update ResourceHealth.json

fixed PR checks

* Update ResourceHealth.json

fixed PR checks

* Update ResourceHealth.json

trying to fix

* Prettie changes 2 files

* Update Operations_List.json

fixed PR comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants