[Batch] Rollback the support for TokenCredential#16870
Merged
deyaaeldeen merged 4 commits intoAzure:mainfrom Aug 12, 2021
Merged
[Batch] Rollback the support for TokenCredential#16870deyaaeldeen merged 4 commits intoAzure:mainfrom
deyaaeldeen merged 4 commits intoAzure:mainfrom
Conversation
ramya-rao-a
suggested changes
Aug 11, 2021
sdk/batch/batch/README.md
Outdated
| ##### Authentication | ||
|
|
||
| ### How to use | ||
| 1. Use `AzureCliCredentials` exported from `@azure/ms-rest-nodeauth`. |
Contributor
There was a problem hiding this comment.
What is the benefit of showing the Azure CLI option over the API key one? Can we skip this and showcase the API key scenario as that is what is shown in the official samples as well?
Member
Author
There was a problem hiding this comment.
This was the readme used earlier, so I kept them to show case how to use nodeauth. To address your feedback, I deleted the CLI one and kept the shared key and the other nodeauth one.
7a96595 to
6704d61
Compare
Member
Author
|
@ramya-rao-a please take a look now. |
ramya-rao-a
reviewed
Aug 12, 2021
ramya-rao-a
approved these changes
Aug 12, 2021
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 25, 2021
Track2 modify readme.go.md (Azure#16870)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 25, 2021
Track2 modify readme.go.md (Azure#16870)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 25, 2021
Track2 modify readme.go.md (Azure#16870)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 5, 2022
Track2 modify readme.go.md (Azure#16870)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 5, 2022
Track2 modify readme.go.md (Azure#16870)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 5, 2022
Track2 modify readme.go.md (Azure#16870)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch has been advertising using shared keys as their primary way of authentication in their docs. #16679 added support for
TokenCredentialauthentication but it turned out that batch is not compatible with the support for token credentials in@azure/ms-rest-jsbecause the latter assumes a scope that only works with management-plane libs.If we want to fix the support for AAD, we will have to add support for custom scopes in
@azure/ms-rest-jsso we can pass the batch scopehttps://batch.core.windows.net//.defaultto it and also updateazureTokenCredentialas follows:Because of the hassle of doing the fix and the fact that AAD support was not advertisied in batch to begin with, we want to go ahead and revert the support for
TokenCredentialinstead.