[Identity] Renamed AZURE_POD_IDENTITY_TOKEN_URL -> AZURE_POD_IDENTITY_AUTHORITY_HOST#16682
Merged
sadasant merged 4 commits intoAzure:mainfrom Aug 9, 2021
Merged
[Identity] Renamed AZURE_POD_IDENTITY_TOKEN_URL -> AZURE_POD_IDENTITY_AUTHORITY_HOST#16682sadasant merged 4 commits intoAzure:mainfrom
sadasant merged 4 commits intoAzure:mainfrom
Conversation
ghost
added
the
chlowell
reviewed
Aug 7, 2021
|
|
||
| return { | ||
| url: process.env.AZURE_POD_IDENTITY_TOKEN_URL ?? `${imdsEndpoint}?${query}`, | ||
| url: `${process.env.AZURE_POD_IDENTITY_AUTHORITY_HOST ?? imdsHost}${imdsEndpointPath}?${query}`, |
Member
There was a problem hiding this comment.
If $AZURE_POD_IDENTITY_AUTHORITY_HOST is https://foo/ you'll end up with https://foo//metadata/identity/oauth2/token
Contributor
Author
There was a problem hiding this comment.
good point! thanks!
KarishmaGhiya
approved these changes
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requester of this feature would prefer to specify only the scheme and host of their IMDS proxy in AZURE_POD_IDENTITY_TOKEN_URL, and have ManagedIdentityCredential form the rest of the URL. This PR adjusts accordingly and renames AZURE_POD_IDENTITY_TOKEN_URL to AZURE_POD_IDENTITY_AUTHORITY_HOST to reflect the change in its expected value.
From: Azure/azure-sdk-for-python#19867
Fixes #16454