Skip to content

Service fabric e2e Identity tests#16187

Closed
KarishmaGhiya wants to merge 12 commits intoAzure:mainfrom
KarishmaGhiya:service-fabric
Closed

Service fabric e2e Identity tests#16187
KarishmaGhiya wants to merge 12 commits intoAzure:mainfrom
KarishmaGhiya:service-fabric

Conversation

@KarishmaGhiya
Copy link
Copy Markdown
Member

@KarishmaGhiya KarishmaGhiya commented Jul 4, 2021

  • Running Identity e2e tests for Service Fabric

@ghost ghost added the Azure.Identity label Jul 4, 2021
@KarishmaGhiya KarishmaGhiya linked an issue Jul 4, 2021 that may be closed by this pull request
Comment thread sdk/identity/identity/test/manual-integration/AzureServiceFabric/INSTRUCTIONS.md Outdated

To use the provided templates:

1. Open `arm-templates/sfmitestsystem.parameters.json` and complete the fields `clusterName`, `clusterLocation`, and `applicationPackageUrl`. `clusterName` and `clusterLocation` should match the name and location of your Service Fabric cluster. `applicationPackageUrl` is the URL of the `.sfpkg` you uploaded to a storage account in the previous step. To find the URL, click on `sfmitestsystem.sfpkg` in the Portal to view its properties.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t find arm-templates/sfmitestsystem.parameters.json in this branch 🤔

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh so it’s the same arm-templates/cluster*?


```
az deployment group create --resource-group $RESOURCE_GROUP --template-file arm-templates\sfmitestsystem.template.json --parameters arm-templates\sfmitestsystem.parameters.json
az deployment group create --resource-group $RESOURCE_GROUP --template-file arm-templates\sfmitestuser.template.json --parameters arm-templates\sfmitestuser.parameters.json
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these two ARM templates don’t exist, and only the arm-templates/cluster* ones exist, these commands need to change.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the similar pairs of commands below.

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Feb 25, 2022
@ghost
Copy link
Copy Markdown

ghost commented Feb 25, 2022

Hi @KarishmaGhiya. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Mar 4, 2022
@ghost
Copy link
Copy Markdown

ghost commented Mar 4, 2022

Hi @KarishmaGhiya. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@KarishmaGhiya KarishmaGhiya reopened this Mar 5, 2022
@KarishmaGhiya
Copy link
Copy Markdown
Member Author

KarishmaGhiya commented Mar 5, 2022

We'd like to keep this PR open till we get some more time to start working on this again. Need to reference both these - Azure/azure-sdk#901 (comment) and Azure/azure-sdk-for-python#21370

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Mar 5, 2022
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label May 6, 2022
@ghost
Copy link
Copy Markdown

ghost commented May 6, 2022

Hi @KarishmaGhiya. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this May 13, 2022
@ghost
Copy link
Copy Markdown

ghost commented May 13, 2022

Hi @KarishmaGhiya. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@KarishmaGhiya KarishmaGhiya removed the no-recent-activity There has been no recent activity on this issue. label Jun 13, 2022
@KarishmaGhiya KarishmaGhiya added this to the Backlog milestone Jun 13, 2022
@KarishmaGhiya KarishmaGhiya reopened this Jun 13, 2022
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Aug 19, 2022
@ghost
Copy link
Copy Markdown

ghost commented Aug 19, 2022

Hi @KarishmaGhiya. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Aug 27, 2022
@ghost
Copy link
Copy Markdown

ghost commented Aug 27, 2022

Hi @KarishmaGhiya. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@xirzec xirzec removed this from the Backlog milestone Nov 1, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Identity no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Identity e2e tests for running in Azure Service Fabric

3 participants