Skip to content

Conversation

@bashimoha
Copy link
Contributor

this fixes #6449

Comment on lines +11 to +13
- [Product documentation][doc_product]
- [Direct methods][doc_direct_methods]
- [Source code][source]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hivyas could you please populate these links and perhaps use our standard ones?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind, I just found the links below. However, maybe it is still a good idea to use our standard key links list.

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the master change back to main, I pointed to some of the places that had this issue but it looks like all links need to be revisited.

@bashimoha
Copy link
Contributor Author

bashimoha commented Jun 30, 2021

Please revert the master change back to main, I pointed to some of the places that had this issue but it looks like all links need to be revisited.

sorry I am having trouble understanding "revert the master change back to main" do you mean I should change the word from master to main? if so then the URL is changing itself to main when I paste the link to the url bar

@deyaaeldeen
Copy link
Member

if so then the URL is changing itself to main when I paste the link to the url bar

Yes, but why do you want to rely on this behavior? why changing the word main to master again? we removed the word master for a reason so we do not want to see it again in our READMEs. Thanks.

@bashimoha
Copy link
Contributor Author

if so then the URL is changing itself to main when I paste the link to the url bar

Yes, but why do you want to rely on this behavior? why changing the word main to master again? we removed the word master for a reason so we do not want to see it again in our READMEs. Thanks.

I see what you mean. I didn't have idea that I changed it, maybe when I was trying to resolve the conflict? I will try to change it the way it was.

@bashimoha
Copy link
Contributor Author

if so then the URL is changing itself to main when I paste the link to the url bar

Yes, but why do you want to rely on this behavior? why changing the word main to master again? we removed the word master for a reason so we do not want to see it again in our READMEs. Thanks.

I try to changed it to the way it was, are those okay?

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left one minor comment

@deyaaeldeen deyaaeldeen merged commit dc60598 into Azure:main Jul 6, 2021
@deyaaeldeen
Copy link
Member

@bashimoha Thanks! I merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Configuration Azure.ApplicationModel.Configuration Azure.Core Azure.Identity Cognitive - Form Recognizer Cognitive - Metrics Advisor Cognitive - Text Analytics Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Grid Event Hubs KeyVault Monitor Monitor, Monitor Ingestion, Monitor Query Search Service Bus Storage Storage Service (Queues, Blobs, Files) Tables

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Readme] multiple links on a single line is hard to read

3 participants