-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Dispaly links as list #16117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispaly links as list #16117
Conversation
| - [Product documentation][doc_product] | ||
| - [Direct methods][doc_direct_methods] | ||
| - [Source code][source] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hivyas could you please populate these links and perhaps use our standard ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never mind, I just found the links below. However, maybe it is still a good idea to use our standard key links list.
deyaaeldeen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the master change back to main, I pointed to some of the places that had this issue but it looks like all links need to be revisited.
sorry I am having trouble understanding "revert the master change back to main" do you mean I should change the word from master to main? if so then the URL is changing itself to main when I paste the link to the url bar |
Yes, but why do you want to rely on this behavior? why changing the word main to master again? we removed the word master for a reason so we do not want to see it again in our READMEs. Thanks. |
I see what you mean. I didn't have idea that I changed it, maybe when I was trying to resolve the conflict? I will try to change it the way it was. |
I try to changed it to the way it was, are those okay? |
fixed a type in the link
deyaaeldeen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left one minor comment
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
|
@bashimoha Thanks! I merged the PR. |
this fixes #6449