Convenience Method to create a synonymmap object#16054
Merged
sarangan12 merged 3 commits intoAzure:mainfrom Jun 29, 2021
Merged
Convenience Method to create a synonymmap object#16054sarangan12 merged 3 commits intoAzure:mainfrom
sarangan12 merged 3 commits intoAzure:mainfrom
Conversation
ghost
added
the
xirzec
requested changes
Jun 28, 2021
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
Seems useful!
I think there is a small bug with more than 2 lines in the file, though.
| @@ -0,0 +1,2 @@ | |||
| United States, United States of America => USA | |||
| Washington, Wash. => WA No newline at end of file | |||
Member
There was a problem hiding this comment.
Can we add a third line to this test to catch the "only replace a single \r" bug?
Member
There was a problem hiding this comment.
I don't see it in the latest revision?
Contributor
Author
There was a problem hiding this comment.
I added an empty line at the end of the test file. It is not showing up in the diff.
Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
xirzec
approved these changes
Jun 29, 2021
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
The code looks good now, but I don't see the tests you added. Maybe you forgot to push them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to Issue #14664. This PR creates a convenience method that creates a synonymmap object.
A similar method is implemented in Java and could be found here: https://github.com/Azure/azure-sdk-for-java/pull/20984/files
@xirzec Please review and approve
@ramya-rao-a FYI....