Skip to content

update the redundant responses #16051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KarishmaGhiya merged 1 commit into from
Jun 28, 2021
Merged

update the redundant responses #16051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 17 additions & 35 deletions sdk/metricsadvisor/ai-metrics-advisor/review/ai-metrics-advisor.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,24 +523,6 @@ export type FeedbackQueryTimeMode = "MetricTimestamp" | "FeedbackCreatedTime";
// @public
export type FeedbackType = "Anomaly" | "ChangePoint" | "Period" | "Comment";

// @public
export type GetAlertConfigResponse = AnomalyAlertConfiguration;

// @public
export type GetDataFeedResponse = MetricsAdvisorDataFeed;

// @public
export type GetDataSourceCredentialEntityResponse = DataSourceCredentialEntityUnion;

// @public
export type GetDetectionConfigResponse = AnomalyDetectionConfiguration;

// @public
export type GetFeedbackResponse = MetricFeedbackUnion;

// @public
export type GetHookResponse = NotificationHookUnion;

// @public
export type GetIncidentRootCauseResponse = {
rootCauses: IncidentRootCause[];
Expand Down Expand Up @@ -869,35 +851,35 @@ export type MetricPeriodFeedback = {
// @public
export class MetricsAdvisorAdministrationClient {
constructor(endpointUrl: string, credential: TokenCredential | MetricsAdvisorKeyCredential, options?: MetricsAdvisorAdministrationClientOptions);
createAlertConfig(config: Omit<AnomalyAlertConfiguration, "id">, options?: OperationOptions): Promise<GetAlertConfigResponse>;
createDataFeed(feed: DataFeedDescriptor, operationOptions?: CreateDataFeedOptions): Promise<GetDataFeedResponse>;
createDataSourceCredential(dataSourceCredential: DataSourceCredentialEntityUnion, options?: OperationOptions): Promise<GetDataSourceCredentialEntityResponse>;
createDetectionConfig(config: Omit<AnomalyDetectionConfiguration, "id">, options?: OperationOptions): Promise<GetDetectionConfigResponse>;
createHook(hookInfo: EmailNotificationHook | WebNotificationHook, options?: OperationOptions): Promise<GetHookResponse>;
createAlertConfig(config: Omit<AnomalyAlertConfiguration, "id">, options?: OperationOptions): Promise<AnomalyAlertConfiguration>;
createDataFeed(feed: DataFeedDescriptor, operationOptions?: CreateDataFeedOptions): Promise<MetricsAdvisorDataFeed>;
createDataSourceCredential(dataSourceCredential: DataSourceCredentialEntityUnion, options?: OperationOptions): Promise<DataSourceCredentialEntityUnion>;
createDetectionConfig(config: Omit<AnomalyDetectionConfiguration, "id">, options?: OperationOptions): Promise<AnomalyDetectionConfiguration>;
createHook(hookInfo: EmailNotificationHook | WebNotificationHook, options?: OperationOptions): Promise<NotificationHookUnion>;
deleteAlertConfig(id: string, options?: OperationOptions): Promise<RestResponse>;
deleteDataFeed(id: string, options?: OperationOptions): Promise<RestResponse>;
deleteDataSourceCredential(id: string, options?: OperationOptions): Promise<RestResponse>;
deleteDetectionConfig(id: string, options?: OperationOptions): Promise<RestResponse>;
deleteHook(id: string, options?: OperationOptions): Promise<RestResponse>;
readonly endpointUrl: string;
getAlertConfig(id: string, options?: OperationOptions): Promise<GetAlertConfigResponse>;
getDataFeed(id: string, options?: OperationOptions): Promise<GetDataFeedResponse>;
getAlertConfig(id: string, options?: OperationOptions): Promise<AnomalyAlertConfiguration>;
getDataFeed(id: string, options?: OperationOptions): Promise<MetricsAdvisorDataFeed>;
getDataFeedIngestionProgress(dataFeedId: string, options?: {}): Promise<GetIngestionProgressResponse>;
getDataSourceCredential(id: string, options?: OperationOptions): Promise<GetDataSourceCredentialEntityResponse>;
getDetectionConfig(id: string, options?: OperationOptions): Promise<GetDetectionConfigResponse>;
getHook(id: string, options?: OperationOptions): Promise<GetHookResponse>;
getDataSourceCredential(id: string, options?: OperationOptions): Promise<DataSourceCredentialEntityUnion>;
getDetectionConfig(id: string, options?: OperationOptions): Promise<AnomalyDetectionConfiguration>;
getHook(id: string, options?: OperationOptions): Promise<NotificationHookUnion>;
listAlertConfigs(detectionConfigId: string, options?: OperationOptions): PagedAsyncIterableIterator<AnomalyAlertConfiguration, AlertConfigurationsPageResponse, undefined>;
listDataFeedIngestionStatus(dataFeedId: string, startTime: Date | string, endTime: Date | string, options?: ListDataFeedIngestionStatusOptions): PagedAsyncIterableIterator<IngestionStatus, IngestionStatusPageResponse>;
listDataFeeds(options?: ListDataFeedsOptions): PagedAsyncIterableIterator<MetricsAdvisorDataFeed, DataFeedsPageResponse>;
listDataSourceCredential(options?: ListDataSourceCredentialsOptions): PagedAsyncIterableIterator<DataSourceCredentialEntityUnion, CredentialsPageResponse>;
listDetectionConfigs(metricId: string, options?: OperationOptions): PagedAsyncIterableIterator<AnomalyDetectionConfiguration, DetectionConfigurationsPageResponse, undefined>;
listHooks(options?: ListHooksOptions): PagedAsyncIterableIterator<NotificationHookUnion, HooksPageResponse>;
refreshDataFeedIngestion(dataFeedId: string, startTime: Date | string, endTime: Date | string, options?: OperationOptions): Promise<RestResponse>;
updateAlertConfig(id: string, patch: Partial<Omit<AnomalyAlertConfiguration, "id">>, options?: OperationOptions): Promise<GetAlertConfigResponse>;
updateDataFeed(dataFeedId: string, patch: DataFeedPatch, options?: OperationOptions): Promise<GetDataFeedResponse>;
updateDataSourceCredential(id: string, patch: DataSourceCredentialPatch, options?: OperationOptions): Promise<GetDataSourceCredentialEntityResponse>;
updateDetectionConfig(id: string, patch: AnomalyDetectionConfigurationPatch, options?: OperationOptions): Promise<GetDetectionConfigResponse>;
updateHook(id: string, patch: EmailNotificationHookPatch | WebNotificationHookPatch, options?: OperationOptions): Promise<GetHookResponse>;
updateAlertConfig(id: string, patch: Partial<Omit<AnomalyAlertConfiguration, "id">>, options?: OperationOptions): Promise<AnomalyAlertConfiguration>;
updateDataFeed(dataFeedId: string, patch: DataFeedPatch, options?: OperationOptions): Promise<MetricsAdvisorDataFeed>;
updateDataSourceCredential(id: string, patch: DataSourceCredentialPatch, options?: OperationOptions): Promise<DataSourceCredentialEntityUnion>;
updateDetectionConfig(id: string, patch: AnomalyDetectionConfigurationPatch, options?: OperationOptions): Promise<AnomalyDetectionConfiguration>;
updateHook(id: string, patch: EmailNotificationHookPatch | WebNotificationHookPatch, options?: OperationOptions): Promise<NotificationHookUnion>;
}

// @public
Expand All @@ -907,9 +889,9 @@ export interface MetricsAdvisorAdministrationClientOptions extends PipelineOptio
// @public
export class MetricsAdvisorClient {
constructor(endpointUrl: string, credential: TokenCredential | MetricsAdvisorKeyCredential, options?: MetricsAdvisorClientOptions);
addFeedback(feedback: MetricFeedbackUnion, options?: OperationOptions): Promise<GetFeedbackResponse>;
addFeedback(feedback: MetricFeedbackUnion, options?: OperationOptions): Promise<MetricFeedbackUnion>;
readonly endpointUrl: string;
getFeedback(id: string, options?: OperationOptions): Promise<GetFeedbackResponse>;
getFeedback(id: string, options?: OperationOptions): Promise<MetricFeedbackUnion>;
getIncidentRootCauses(detectionConfigId: string, incidentId: string, options?: OperationOptions): Promise<GetIncidentRootCauseResponse>;
getMetricEnrichedSeriesData(detectionConfigId: string, seriesKey: DimensionKey[], startTime: Date | string, endTime: Date | string, options?: GetMetricEnrichedSeriesDataOptions): Promise<GetMetricEnrichedSeriesDataResponse>;
getMetricSeriesData(metricId: string, seriesKey: DimensionKey[], startTime: Date | string, endTime: Date | string, options?: GetMetricSeriesDataOptions): Promise<GetMetricSeriesDataResponse>;
Expand Down
4 changes: 2 additions & 2 deletions sdk/metricsadvisor/ai-metrics-advisor/samples-dev/dataFeed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dotenv.config();
import {
MetricsAdvisorKeyCredential,
MetricsAdvisorAdministrationClient,
GetDataFeedResponse,
MetricsAdvisorDataFeed,
DataFeedPatch,
DataFeedDescriptor
} from "@azure/ai-metrics-advisor";
Expand Down Expand Up @@ -73,7 +73,7 @@ async function listDataFeeds(client: MetricsAdvisorAdministrationClient) {

async function createDataFeed(
client: MetricsAdvisorAdministrationClient
): Promise<GetDataFeedResponse> {
): Promise<MetricsAdvisorDataFeed> {
console.log("Creating Datafeed...");
const feed: DataFeedDescriptor = {
name: "test-datafeed-" + new Date().getTime().toString(),
Expand Down
4 changes: 2 additions & 2 deletions sdk/metricsadvisor/ai-metrics-advisor/samples-dev/dataSourceCredential.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dotenv.config();
import {
MetricsAdvisorKeyCredential,
MetricsAdvisorAdministrationClient,
GetDataSourceCredentialEntityResponse,
DataSourceCredentialEntityUnion,
DataSourceCredentialPatch,
DataSourceSqlConnectionString
} from "@azure/ai-metrics-advisor";
Expand Down Expand Up @@ -73,7 +73,7 @@ async function listDataSourceCredentials(client: MetricsAdvisorAdministrationCli

async function createDataSourceCredential(
client: MetricsAdvisorAdministrationClient
): Promise<GetDataSourceCredentialEntityResponse> {
): Promise<DataSourceCredentialEntityUnion> {
console.log("Creating DataSource credential...");
const datasourceCredential: DataSourceSqlConnectionString = {
name: "Sql-server-cred",
Expand Down
4 changes: 2 additions & 2 deletions sdk/metricsadvisor/ai-metrics-advisor/samples-dev/quickstart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
MetricsAdvisorKeyCredential,
MetricsAdvisorAdministrationClient,
AnomalyAlert,
GetDataFeedResponse,
MetricsAdvisorDataFeed,
MetricsAdvisorClient,
WebNotificationHook,
DataFeedDescriptor,
Expand Down Expand Up @@ -91,7 +91,7 @@ async function createDataFeed(
adminClient: MetricsAdvisorAdministrationClient,
sqlServerConnectionString: string,
sqlServerQuery: string
): Promise<GetDataFeedResponse> {
): Promise<MetricsAdvisorDataFeed> {
console.log("Creating Datafeed...");
const dataFeed: DataFeedDescriptor = {
name: "test_datafeed_" + new Date().getTime().toString(),
Expand Down
2 changes: 1 addition & 1 deletion sdk/metricsadvisor/ai-metrics-advisor/samples/v1/javascript/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ These sample programs show how to use the JavaScript client libraries for Azure

## Prerequisites

The sample programs are compatible with Node.js >=12.0.0.
The sample programs are compatible with [LTS versions of Node.js](https://nodejs.org/about/releases/).

You need [an Azure subscription][freesub] and the following Azure resources to run these sample programs:

Expand Down
2 changes: 1 addition & 1 deletion sdk/metricsadvisor/ai-metrics-advisor/samples/v1/typescript/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ These sample programs show how to use the TypeScript client libraries for Azure

## Prerequisites

The sample programs are compatible with Node.js >=12.0.0.
The sample programs are compatible with [LTS versions of Node.js](https://nodejs.org/about/releases/).

Before running the samples in Node, they must be compiled to JavaScript using the TypeScript compiler. For more information on TypeScript, see the [TypeScript documentation][typescript]. Install the TypeScript compiler using:

Expand Down
4 changes: 2 additions & 2 deletions sdk/metricsadvisor/ai-metrics-advisor/samples/v1/typescript/src/dataFeed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dotenv.config();
import {
MetricsAdvisorKeyCredential,
MetricsAdvisorAdministrationClient,
GetDataFeedResponse,
MetricsAdvisorDataFeed,
DataFeedPatch,
DataFeedDescriptor
} from "@azure/ai-metrics-advisor";
Expand Down Expand Up @@ -72,7 +72,7 @@ async function listDataFeeds(client: MetricsAdvisorAdministrationClient) {

async function createDataFeed(
client: MetricsAdvisorAdministrationClient
): Promise<GetDataFeedResponse> {
): Promise<MetricsAdvisorDataFeed> {
console.log("Creating Datafeed...");
const feed: DataFeedDescriptor = {
name: "test-datafeed-" + new Date().getTime().toString(),
Expand Down
4 changes: 2 additions & 2 deletions sdk/metricsadvisor/ai-metrics-advisor/samples/v1/typescript/src/dataSourceCredential.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dotenv.config();
import {
MetricsAdvisorKeyCredential,
MetricsAdvisorAdministrationClient,
GetDataSourceCredentialEntityResponse,
DataSourceCredentialEntityUnion,
DataSourceCredentialPatch,
DataSourceSqlConnectionString
} from "@azure/ai-metrics-advisor";
Expand Down Expand Up @@ -72,7 +72,7 @@ async function listDataSourceCredentials(client: MetricsAdvisorAdministrationCli

async function createDataSourceCredential(
client: MetricsAdvisorAdministrationClient
): Promise<GetDataSourceCredentialEntityResponse> {
): Promise<DataSourceCredentialEntityUnion> {
console.log("Creating DataSource credential...");
const datasourceCredential: DataSourceSqlConnectionString = {
name: "Sql-server-cred",
Expand Down
4 changes: 2 additions & 2 deletions sdk/metricsadvisor/ai-metrics-advisor/samples/v1/typescript/src/quickstart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
MetricsAdvisorKeyCredential,
MetricsAdvisorAdministrationClient,
AnomalyAlert,
GetDataFeedResponse,
MetricsAdvisorDataFeed,
MetricsAdvisorClient,
WebNotificationHook,
DataFeedDescriptor,
Expand Down Expand Up @@ -90,7 +90,7 @@ async function createDataFeed(
adminClient: MetricsAdvisorAdministrationClient,
sqlServerConnectionString: string,
sqlServerQuery: string
): Promise<GetDataFeedResponse> {
): Promise<MetricsAdvisorDataFeed> {
console.log("Creating Datafeed...");
const dataFeed: DataFeedDescriptor = {
name: "test_datafeed_" + new Date().getTime().toString(),
Expand Down
37 changes: 16 additions & 21 deletions sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorAdministrationClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ import {
EmailNotificationHookPatch,
AnomalyDetectionConfiguration,
AnomalyDetectionConfigurationPatch,
GetDataFeedResponse,
GetDetectionConfigResponse,
GetAlertConfigResponse,
GetHookResponse,
NotificationHookUnion,
DataFeedAutoRollupMethod,
DataFeedsPageResponse,
Expand All @@ -47,8 +43,7 @@ import {
AnomalyAlertConfiguration,
DataSourceCredentialEntityUnion,
DataSourceCredentialPatch,
CredentialsPageResponse,
GetDataSourceCredentialEntityResponse
CredentialsPageResponse
} from "./models";
import { DataSourceType, HookInfoUnion, NeedRollupEnum } from "./generated/models";
import {
Expand Down Expand Up @@ -200,7 +195,7 @@ export class MetricsAdvisorAdministrationClient {
public async createDataFeed(
feed: DataFeedDescriptor,
operationOptions: CreateDataFeedOptions = {}
): Promise<GetDataFeedResponse> {
): Promise<MetricsAdvisorDataFeed> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-createDataFeed",
operationOptions
Expand Down Expand Up @@ -298,7 +293,7 @@ export class MetricsAdvisorAdministrationClient {
public async getDataFeed(
id: string,
options: OperationOptions = {}
): Promise<GetDataFeedResponse> {
): Promise<MetricsAdvisorDataFeed> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-getDataFeed",
options
Expand Down Expand Up @@ -466,7 +461,7 @@ export class MetricsAdvisorAdministrationClient {
dataFeedId: string,
patch: DataFeedPatch,
options: OperationOptions = {}
): Promise<GetDataFeedResponse> {
): Promise<MetricsAdvisorDataFeed> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-updateDataFeed",
options
Expand Down Expand Up @@ -554,7 +549,7 @@ export class MetricsAdvisorAdministrationClient {
public async createDetectionConfig(
config: Omit<AnomalyDetectionConfiguration, "id">,
options: OperationOptions = {}
): Promise<GetDetectionConfigResponse> {
): Promise<AnomalyDetectionConfiguration> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-createDetectionConfig",
options
Expand Down Expand Up @@ -592,7 +587,7 @@ export class MetricsAdvisorAdministrationClient {
public async getDetectionConfig(
id: string,
options: OperationOptions = {}
): Promise<GetDetectionConfigResponse> {
): Promise<AnomalyDetectionConfiguration> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-getDetectionConfig",
options
Expand Down Expand Up @@ -624,7 +619,7 @@ export class MetricsAdvisorAdministrationClient {
id: string,
patch: AnomalyDetectionConfigurationPatch,
options: OperationOptions = {}
): Promise<GetDetectionConfigResponse> {
): Promise<AnomalyDetectionConfiguration> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-updateDetectionConfig",
options
Expand Down Expand Up @@ -687,7 +682,7 @@ export class MetricsAdvisorAdministrationClient {
public async createAlertConfig(
config: Omit<AnomalyAlertConfiguration, "id">,
options: OperationOptions = {}
): Promise<GetAlertConfigResponse> {
): Promise<AnomalyAlertConfiguration> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-createAlertConfig",
options
Expand Down Expand Up @@ -726,7 +721,7 @@ export class MetricsAdvisorAdministrationClient {
id: string,
patch: Partial<Omit<AnomalyAlertConfiguration, "id">>,
options: OperationOptions = {}
): Promise<GetAlertConfigResponse> {
): Promise<AnomalyAlertConfiguration> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-updateAlertConfig",
options
Expand Down Expand Up @@ -761,7 +756,7 @@ export class MetricsAdvisorAdministrationClient {
public async getAlertConfig(
id: string,
options: OperationOptions = {}
): Promise<GetAlertConfigResponse> {
): Promise<AnomalyAlertConfiguration> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-getAlertConfig",
options
Expand Down Expand Up @@ -933,7 +928,7 @@ export class MetricsAdvisorAdministrationClient {
public async createHook(
hookInfo: EmailNotificationHook | WebNotificationHook,
options: OperationOptions = {}
): Promise<GetHookResponse> {
): Promise<NotificationHookUnion> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-createHook",
options
Expand Down Expand Up @@ -975,7 +970,7 @@ export class MetricsAdvisorAdministrationClient {
* @param options - The options parameter.
*/

public async getHook(id: string, options: OperationOptions = {}): Promise<GetHookResponse> {
public async getHook(id: string, options: OperationOptions = {}): Promise<NotificationHookUnion> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-getHook",
options
Expand Down Expand Up @@ -1126,7 +1121,7 @@ export class MetricsAdvisorAdministrationClient {
id: string,
patch: EmailNotificationHookPatch | WebNotificationHookPatch,
options: OperationOptions = {}
): Promise<GetHookResponse> {
): Promise<NotificationHookUnion> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-updateHook",
options
Expand Down Expand Up @@ -1554,7 +1549,7 @@ export class MetricsAdvisorAdministrationClient {
public async createDataSourceCredential(
dataSourceCredential: DataSourceCredentialEntityUnion,
options: OperationOptions = {}
): Promise<GetDataSourceCredentialEntityResponse> {
): Promise<DataSourceCredentialEntityUnion> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-createDataSourceCredential",
options
Expand Down Expand Up @@ -1590,7 +1585,7 @@ export class MetricsAdvisorAdministrationClient {
public async getDataSourceCredential(
id: string,
options: OperationOptions = {}
): Promise<GetDataSourceCredentialEntityResponse> {
): Promise<DataSourceCredentialEntityUnion> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-getDataSourceCredential",
options
Expand Down Expand Up @@ -1748,7 +1743,7 @@ export class MetricsAdvisorAdministrationClient {
id: string,
patch: DataSourceCredentialPatch,
options: OperationOptions = {}
): Promise<GetDataSourceCredentialEntityResponse> {
): Promise<DataSourceCredentialEntityUnion> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorAdministrationClient-updateDataSourceCredential",
options
Expand Down
5 changes: 2 additions & 3 deletions sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import {
AnomalyAlert,
GetMetricEnrichedSeriesDataResponse,
GetIncidentRootCauseResponse,
GetFeedbackResponse,
AlertsPageResponse,
IncidentsPageResponse,
AnomaliesPageResponse,
Expand Down Expand Up @@ -1445,7 +1444,7 @@ export class MetricsAdvisorClient {
public async addFeedback(
feedback: MetricFeedbackUnion,
options: OperationOptions = {}
): Promise<GetFeedbackResponse> {
): Promise<MetricFeedbackUnion> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorClient-addFeedback",
options
Expand Down Expand Up @@ -1480,7 +1479,7 @@ export class MetricsAdvisorClient {
public async getFeedback(
id: string,
options: OperationOptions = {}
): Promise<GetFeedbackResponse> {
): Promise<MetricFeedbackUnion> {
const { span, updatedOptions: finalOptions } = createSpan(
"MetricsAdvisorClient-getFeedback",
options
Expand Down
Loading