[EventGrid] Move to Core V2 Generator#16047
Merged
ellismg merged 2 commits intoAzure:mainfrom Jun 28, 2021
Merged
Conversation
As part of the development of the new pipeline, event grid was hand ported to use the new pipeline. Now that the code generator targets the new pipeline, we can start using it to generate the code. Since EventGrid includes the `/api/events` path segement in the Endpoint, We need to do a small amount of post processing of the generated code, to ensure `/api/events` is not appended to the endpoint (we do this by setting an empty path in the operation spec, which is as things were before moving over to the generator). Fixes Azure#15823
deyaaeldeen
reviewed
Jun 28, 2021
xirzec
approved these changes
Jun 28, 2021
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
While it's unfortunate you need to do the workaround for the path, I'm actually pretty happy with how you encapsulated it. I might use this pattern in other places where the codegen is bugged. 😉
deyaaeldeen
approved these changes
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the development of the new pipeline, event grid was hand
ported to use the new pipeline. Now that the code generator targets
the new pipeline, we can start using it to generate the code.
Since EventGrid includes the
/api/eventspath segement in theEndpoint, We need to do a small amount of post processing of the
generated code, to ensure
/api/eventsis not appended to theendpoint (we do this by setting an empty path in the operation spec,
which is as things were before moving over to the generator).
Fixes #15823