update pipeline to releae/track1#15993
Conversation
|
@praveenkuttappan Please review |
eng/pipelines/mgmt-ci.yml
Outdated
| branches: | ||
| include: | ||
| - main | ||
| - feature/v4 |
There was a problem hiding this comment.
I suggest we just use our common pattern for both of these ci.yml files:
- main
- feature/*
- release/*
- hotfix/*
That way this pipeline will trigger for any branch follow the given pattern.
There was a problem hiding this comment.
See https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/core/ci.yml#L21-L24 as an example of the common pattern in the repo.
There was a problem hiding this comment.
If you ever plan to fork off a hotfix or release branch it might still be worth having those branch names as triggers. However we can add those later as needed.
weshaggard
left a comment
There was a problem hiding this comment.
Note that you will need to also update the pipelines in devops to point the default branch or any scheduled triggers to use feature/v4 as the branch instead of main.
Just as an FYI I checked and there are now ci or scheduled triggers for these pipeline so I think you are good. |
In the period of track2 sdk preview, we are going to use branch
feature/v4to continue the release of track1 sdk.Besides this PR, I will also change the the release pipeline to trigger in branch
feature/v4