Support track2 management packages #15975
Conversation
praveenkuttappan
added
the
Central-EngSys
praveenkuttappan
requested review from
danieljurek,
mikeharder,
mitchdenny and
weshaggard
as code owners
praveenkuttappan
requested review from
KarishmaGhiya,
dw511214992 and
ramya-rao-a
|
I think I will need a change in gulp scrip as well to skip track2 mgmt from track1 pipeline. |
eng/tools/rush-runner.js
Outdated
| for (const filePath of packageJsons) { | ||
| const contents = JSON.parse(fs.readFileSync(filePath, "utf8")); | ||
| if (contents["sdk-type"] === "client") { | ||
| if (contents["sdk-type"] === "client" || contents["sdk-type"] === "management") { |
There was a problem hiding this comment.
| if (contents["sdk-type"] === "client" || contents["sdk-type"] === "management") { | |
| if (contents["sdk-type"] === "client" || contents["sdk-type"] === "mgmt") { |
Most other places call this mgmt so lets do that here as well.
There was a problem hiding this comment.
@sarangan12 just made changes to the code generator to use management.
@praveenkuttappan Please confirm which way we want to go here so that @sarangan12 can make the changes appropriately
There was a problem hiding this comment.
@praveenkuttappan I prefer mgmt, which is used in most places for management plane.
There was a problem hiding this comment.
@praveenkuttappan will you change it to mgmt?
@ramya-rao-a @sarangan12 I have found the codegen has used management, please confirm which will we use? I just checked some other places, such as https://github.com/Azure/azure-sdk/tree/main/eng#csv-fields, I think mgmt is usually used.
There was a problem hiding this comment.
I will change my PR to look for mgmt. @sarangan12 : Can you please change it to mgmt in code gen.
@praveenkuttappan We will create a branch |
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Looks like a good first step. We will eventually need to make more tweaks to things in the langauge-settings.ps1 to ensure the properties are set correctly
4 participants
Change to include track2 management package in rush runner script.