[Service Bus] Update amqp-common, ms-rest-azure#1596
Merged
ramya-rao-a merged 9 commits intoAzure:masterfrom Mar 28, 2019
Merged
[Service Bus] Update amqp-common, ms-rest-azure#1596ramya-rao-a merged 9 commits intoAzure:masterfrom
ramya-rao-a merged 9 commits intoAzure:masterfrom
Conversation
ghost
added
the
ramya-rao-a
reviewed
Mar 16, 2019
ramya-rao-a
reviewed
Mar 16, 2019
ramya-rao-a
reviewed
Mar 22, 2019
ramya-rao-a
reviewed
Mar 27, 2019
ramya-rao-a
approved these changes
Mar 28, 2019
HarshaNalluru
pushed a commit
to HarshaNalluru/azure-sdk-for-js
that referenced
this pull request
Apr 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the amqp-common dependency to point to Azure/amqp-common-js#29 and serves as a base for testing those changes. This change also updates ms-rest-azure to the newer @azure/ms-rest-js. This commit will serve as a base for ongoing browserification work.
All tests are passing locally.