[Identity] node-fetch takes above 2 seconds to send the request on some environments#15937
Merged
sadasant merged 1 commit intoAzure:mainfrom Jun 28, 2021
Merged
Conversation
ghost
added
the
xirzec
approved these changes
Jun 28, 2021
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
I'm not opposed to this change, though can you file a tracking bug to remove this as part of the switch to corev2?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we stopped using node-fetch on core-rest-pipeline, core-http does use it. Node fetch takes above 2 seconds to begin sending network requests in some environments. We’re able to reproduce this issue in Kubernetes pods, but it could be present elsewhere.
This PR increases the timeout to 3 seconds.
I believe this should be ok as a temporary solution, since in many cases, we will get a response (any response) before that time.
For Identity. we should be able to solve this as soon as we move Identity to core-rest-pipeline: #15595 We’re planning to do this during July. However, that won’t solve the issue in core-http.
This issue is related to: #15935
It won’t fix #15935, but it will help us have an immediate aid for our customers.