Skip to content

Test common changes #15919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
praveenkuttappan wants to merge 8 commits into from
Closed

Test common changes #15919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e35aab4
Test common changes
praveenkuttappan Jun 23, 2021
59f127b
Test common changes
praveenkuttappan Jun 23, 2021
d5ad43e
Add ReleaseDAte property
praveenkuttappan Jun 23, 2021
9fb05e6
Test more common changes
praveenkuttappan Jun 23, 2021
c658fd4
Test more common changes
praveenkuttappan Jun 23, 2021
50249f6
Test more common changes
praveenkuttappan Jun 23, 2021
6af138b
Test template package API review
praveenkuttappan Jun 23, 2021
01a3a4e
SEt release date for template package
praveenkuttappan Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eng/common/scripts/Create-APIReview.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ if ($packages)
# Ignore API review status for prerelease version
Write-Host "Package version is not GA. Ignoring API view approval status"
}
elseif (!$pkgInfo.ReleaseDate -or $pkgInfo.ReleaseDate -eq "Unreleased")
{
Write-Host "Release date is not set for current version in change log file for package. Ignoring API review approval status since package is not yet ready for release."
}
else
{
# Return error code if status code is 201 for new data plane package
Expand Down
7 changes: 7 additions & 0 deletions eng/common/scripts/Package-Properties.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class PackageProps
[string]$SdkType
[boolean]$IsNewSdk
[string]$ArtifactName
[string]$ReleaseDate

PackageProps([string]$name, [string]$version, [string]$directoryPath, [string]$serviceDirectory)
{
Expand Down Expand Up @@ -48,6 +49,12 @@ class PackageProps
if (Test-Path (Join-Path $directoryPath "CHANGELOG.md"))
{
$this.ChangeLogPath = Join-Path $directoryPath "CHANGELOG.md"
# Get release date for current version and set in package property
$changeLogEntry = Get-ChangeLogEntry -ChangeLogLocation $this.ChangeLogPath -VersionString $this.Version
if ($changeLogEntry -and ![System.String]::IsNullOrEmpty($changeLogEntry.ReleaseStatus))
{
$this.ReleaseDate = $changeLogEntry.ReleaseStatus.Trim().Trim("()")
}
}
else
{
Expand Down
1 change: 1 addition & 0 deletions eng/common/scripts/Save-Package-Properties.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ if ($allPackageProperties)
Write-Host "Package Version: $($pkg.Version)"
Write-Host "Package SDK Type: $($pkg.SdkType)"
Write-Host "Artifact Name: $($pkg.ArtifactName)"
Write-Host "Release date: $($pkg.ReleaseDate)"
$configFilePrefix = $pkg.Name
if ($pkg.ArtifactName)
{
Expand Down
6 changes: 0 additions & 6 deletions eng/pipelines/templates/steps/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@ parameters:
ServiceDirectory: not-specified

steps:
- template: /eng/common/pipelines/templates/steps/set-test-pipeline-version.yml
parameters:
PackageName: "@azure/template"
ServiceDirectory: "template"
TestPipeline: ${{ parameters.TestPipeline }}

- pwsh: |
$folder = "${{parameters.ServiceDirectory}}"
if ($folder -eq "*") { $folder = "" }
Expand Down
4 changes: 4 additions & 0 deletions sdk/template/template/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release History

## 1.0.11 (2021-06-23)

- Test Release Pipeline

## 1.0.10-beta.1 (2020-11-16)

- Test Release Pipeline
Expand Down
2 changes: 1 addition & 1 deletion sdk/template/template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@azure/template",
"version": "1.0.11-beta.1",
"version": "1.0.11",
"description": "Example project for learning how to build a client library",
"sdk-type": "client",
"main": "dist/index.js",
Expand Down