[App Config] Add display_name to FeatureFlag#15901
Conversation
ghost
added
the
| } | ||
| const jsonFeatureFlagValue: JsonFeatureFlagValue = { | ||
| id: featureFlag.value.id ?? key.replace(featureFlagPrefix, ""), | ||
| ...featureFlag.value, |
There was a problem hiding this comment.
Were enabled and description the only fields we would miss be removing this line?
I agree it makes sense to remove the line (or move it above the id assignment), just want to ensure we aren't forgetting to set a field that was previously being set.
There was a problem hiding this comment.
Were enabled and description the only fields we would miss be removing this line?
This is the feature flag value.
(or move it above the id assignment)
Moving it would add both displayName and display_name, hence removing.
| }[]; | ||
| }; | ||
| description?: string; | ||
| displayName?: string; |
There was a problem hiding this comment.
So this field will eventually be used in the portal? (And presumably someone writing their own app config viewer could use it as well)
|
Hello @HarshaNalluru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 2 participants
Fixes #15891