Skip to content

[REST Clients] Add lro poller helper #15898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joheredi merged 16 commits into from
Aug 5, 2021
Merged

[REST Clients] Add lro poller helper #15898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
86231c2
initial commit
joheredi Jun 21, 2021
1eb7957
bring LRO in
joheredi Jun 21, 2021
65cd1cd
Integrate core-client-lro into farmbeats
joheredi Jun 22, 2021
b4733b4
use core-lro for LroEngine
deyaaeldeen Jul 19, 2021
99aaf91
format and lint
deyaaeldeen Jul 19, 2021
04548d7
update tests
deyaaeldeen Jul 19, 2021
35b0c7f
edit
deyaaeldeen Jul 19, 2021
462c98f
Update sdk/core/core-client-lro-rest/LICENSE
deyaaeldeen Jul 19, 2021
728286f
fix build
deyaaeldeen Jul 19, 2021
877d37e
remove getPoller
deyaaeldeen Jul 20, 2021
da195e0
revert change in core-client-rest's package.json
deyaaeldeen Jul 20, 2021
231852c
Address feedback
joheredi Jul 20, 2021
72fe1d4
Only expose to end users interval and resumeFrom poller options
joheredi Jul 22, 2021
7dd83ce
Update type locations and lock
joheredi Aug 4, 2021
ef15898
updateIntervalInMs
joheredi Aug 5, 2021
bcb0373
Update surface
joheredi Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions dataplane.code-workspace
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@
"name": "core-client-rest",
"path": "sdk/core/core-client-rest"
},
{
"name": "core-client-lro-rest",
"path": "sdk/core/core-client-lro-rest"
},
{
"name": "ai-document-translator",
"path": "sdk/documenttranslator/ai-document-translator-rest"
Expand Down
5 changes: 5 additions & 0 deletions rush.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,11 @@
"projectFolder": "sdk/core/core-amqp",
"versionPolicyName": "core"
},
{
"packageName": "@azure-rest/core-client-lro",
"projectFolder": "sdk/core/core-client-lro-rest",
"versionPolicyName": "core"
},
{
"packageName": "@azure-rest/core-client",
"projectFolder": "sdk/core/core-client-rest",
Expand Down
2 changes: 2 additions & 0 deletions sdk/agrifood/agrifood-farming-rest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,12 @@
"@azure-rest/core-client-paging": "1.0.0-beta.1",
"@azure-rest/core-client": "1.0.0-beta.6",
"@azure/core-rest-pipeline": "^1.1.0",
"@azure-rest/core-client-lro": "1.0.0-beta.1",
Copy link
Copy Markdown
Member

@deyaaeldeen deyaaeldeen Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted getPoller so I think we can move this dep to devDependencies now unless you want to add getPoller back but I do not see the point for it after the simplified getLongRunningPoller.

Copy link
Copy Markdown
Member Author

@joheredi joheredi Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. Brought back getPoller, see comment above for details

"@azure/logger": "^1.0.0",
"tslib": "^2.2.0"
},
"devDependencies": {
"@azure/core-util": "^1.0.0-beta.1",
"@azure/dev-tool": "^1.0.0",
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
"@azure/identity": "^1.1.0",
Expand Down
109 changes: 54 additions & 55 deletions ...arming-rest/recordings/browsers/farmer_operations/recording_should_create_a_boundary.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

109 changes: 54 additions & 55 deletions ...-farming-rest/recordings/browsers/farmer_operations/recording_should_create_a_farmer.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading