Skip to content

[Communication]: Always use x-ms-date for Hmac #15807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JianpingChen merged 7 commits into from
Jun 18, 2021
Merged

[Communication]: Always use x-ms-date for Hmac #15807

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d5c32c1
Always use x-ms-date for Hmac
Jun 17, 2021
f9d9e33
Try to fix phone number tests
Jun 17, 2021
bab5b77
Still another error in phone number tests
Jun 17, 2021
ebdcfb4
Update phoneNumber session records
Jun 18, 2021
070426f
Update phone numbers node sessions
Jun 18, 2021
39ea8b6
Manually fix node record sessions for phone numbers
Jun 18, 2021
9be8225
Update missed session files
Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...mmunication/communication-common/src/credential/communicationAccessKeyCredentialPolicy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class CommunicationAccessKeyCredentialPolicy extends BaseRequestPolicy {
const verb = webResource.method.toUpperCase();
const utcNow = new Date().toUTCString();
const contentHash = await shaHash(webResource.body || "");
const dateHeader = isNode ? "date" : "x-ms-date";
const dateHeader = "x-ms-date";
const signedHeaders = `${dateHeader};host;x-ms-content-sha256`;

const url = URLBuilder.parse(webResource.url);
Expand Down
2 changes: 1 addition & 1 deletion ...mmunication/communication-identity/test/public/communicationIdentityClient.mocked.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { TestCommunicationIdentityClient } from "./utils/testCommunicationIdenti
import { exchangeTeamsTokenHttpClient, getTokenHttpClient } from "./utils/mockHttpClients";

describe("CommunicationIdentityClient [Mocked]", () => {
const dateHeader = isNode ? "date" : "x-ms-date";
const dateHeader = "x-ms-date";
const user: CommunicationUserIdentifier = { communicationUserId: "ACS_ID" };

afterEach(() => {
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/communication-phone-numbers/test/internal/headers.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe("PhoneNumbersClient - headers", function() {
});

it("sets date header", function() {
const dateHeader = isNode ? "date" : "x-ms-date";
const dateHeader = "x-ms-date";
assert.typeOf(request.headers.get(dateHeader), "string");
});

Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/communication-sms/test/public/smsClient.mocked.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const TEST_NUMBER = "+14255550123";
describe("[mocked] SmsClient", async () => {
const baseUri = "https://contoso.api.fake:443";
const connectionString = `endpoint=${baseUri};accesskey=banana`;
const dateHeader = isNode ? "date" : "x-ms-date";
const dateHeader = "x-ms-date";
let sendRequestSpy: sinon.SinonSpy;
const mockHttpClient: HttpClient = new MockHttpClient(TEST_NUMBER);

Expand Down