[App config] Perf tests #15763
[App config] Perf tests #15763
Conversation
ghost
added
the
HarshaNalluru
requested review from
chradek,
deyaaeldeen,
mikeharder,
praveenkuttappan,
richardpark-msft and
witemple-msft
as code owners
… harshan/app-config/perf-tests
… harshan/app-config/perf-tests
… harshan/app-config/perf-tests
| 4. Run the tests as follows | ||
|
|
||
| - list settings | ||
| - `npm run perf-test:node -- ListSettingsTest --warmup 2 --duration 7 --iterations 2 --parallel 2` |
There was a problem hiding this comment.
is this service rate-limited?
There was a problem hiding this comment.
There is throttling similar to Form recognizer or metrics advisor.
There was a problem hiding this comment.
if the operation is not a LRO, can you experiment with the number for the parallel param if the limit is not too bad?
There was a problem hiding this comment.
The limit is 20,000 requests per hour, it is quite simple to hit the limit.
We'll soon get the proxy-tool so that we don't have to hit the live service all the time.
richardpark-msft
left a comment
richardpark-msft
left a comment
There was a problem hiding this comment.
Looks like you and @deyaaeldeen have some other review feedback to sort out.
I think the code changes look good but something looks wrong about your pnpm-lock changes.
sdk/appconfiguration/perf-tests/app-configuration/test/appConfigBase.spec.ts
Show resolved
Hide resolved
sdk/appconfiguration/perf-tests/app-configuration/test/index.spec.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/perf-tests/app-configuration/test/listSettings.spec.ts
Show resolved
Hide resolved
sdk/appconfiguration/perf-tests/app-configuration/test/listSettings.spec.ts
Show resolved
Hide resolved
| 3. Create a storage account and populate the `.env` file with `APPCONFIG_CONNECTION_STRING` variable. | ||
| 4. Run the tests as follows | ||
|
|
||
| - list settings |
There was a problem hiding this comment.
What's special about these settings?
There was a problem hiding this comment.
list configuration settings? what do you mean?
|
Hello @HarshaNalluru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
[Hub Generated] Public private branch 'raonon-MixedReality-UpdateResourceResponse' (Azure#15763) * Updated response payload to include missing properties * Reverted Identity property * Updated stable/2020_05_01/proxy.json to include missing object properties Co-authored-by: Raymond Ononiwu <[email protected]>
Adds the list test
Closes #13981