Skip to content
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
2c97206
generated code and latest swagger
KarishmaGhiya Jun 15, 2021
85c0413
granularity per second
KarishmaGhiya Jun 15, 2021
341b858
update the response types for update methods
KarishmaGhiya Jun 16, 2021
7a4d5ae
update internal tests
KarishmaGhiya Jun 16, 2021
cf437ec
update tests and samples for update methods
KarishmaGhiya Jun 16, 2021
eb7a3bc
regenerate samples
KarishmaGhiya Jun 16, 2021
48aff6c
update api review
KarishmaGhiya Jun 16, 2021
b106ec7
getmetricenrichedseriesdata and getmetricseriesdata parameter renamed…
KarishmaGhiya Jun 16, 2021
62b6116
update samples
KarishmaGhiya Jun 16, 2021
661d465
update detection operator type name
KarishmaGhiya Jun 16, 2021
2ac26ce
rename dimensionsToSplitAlert
KarishmaGhiya Jun 16, 2021
a0f7210
remove eslint error
KarishmaGhiya Jun 17, 2021
240c9f7
remove eslint comments
KarishmaGhiya Jun 17, 2021
9f91d76
rename datasource to dataSource
KarishmaGhiya Jun 17, 2021
5c2e473
update datasource credential
KarishmaGhiya Jun 18, 2021
7bfe89a
Rename
jeremymeng Jun 18, 2021
68fcd93
publish updated samples
jeremymeng Jun 18, 2021
ce0aab4
Rename
jeremymeng Jun 18, 2021
bded2a6
Rename
jeremymeng Jun 18, 2021
325eff2
Rename
jeremymeng Jun 18, 2021
59f65a3
Fix readme code
jeremymeng Jun 18, 2021
68fd4c7
Rename DataFeed to MetricsAdvisorDataFeed
jeremymeng Jun 18, 2021
13dbd56
split the 2 overloads of listAnomalies into 2 separate functions
KarishmaGhiya Jun 18, 2021
b0278d0
Merge branch 'tttt' into metric-advisor-GA-swagger
jeremymeng Jun 18, 2021
d1723df
listIncidents overloads separated to 2 separate methods
KarishmaGhiya Jun 18, 2021
6a6a7d4
Merge branch 'tttt' into metric-advisor-GA-swagger
jeremymeng Jun 18, 2021
52ced76
Merge pull request #3 from jeremymeng/metric-advisor-GA-swagger
KarishmaGhiya Jun 18, 2021
acbcc90
add doc refs to generated code
KarishmaGhiya Jun 21, 2021
ded9d96
api values for undocumented refs
KarishmaGhiya Jun 21, 2021
2b32c89
revised updated samples
KarishmaGhiya Jun 22, 2021
825a3f4
node recordings for eventhub tests
KarishmaGhiya Jun 24, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
208 changes: 104 additions & 104 deletions sdk/metricsadvisor/ai-metrics-advisor/review/ai-metrics-advisor.api.md

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,7 @@ async function updateAlertConfig(
]
};
console.log(`Updating alerting configuration ${detectionConfigId}`);
await adminClient.updateAlertConfig(alertConfigId, patch);
const updated = await adminClient.getAlertConfig(alertConfigId);
const updated = await adminClient.updateAlertConfig(alertConfigId, patch);
return updated;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ async function updateDataFeed(client: MetricsAdvisorAdministrationClient, dataFe

try {
console.log(`Updating datafeed ${dataFeedId}...`);
await client.updateDataFeed(dataFeedId, patch);
const updated = await client.getDataFeed(dataFeedId);
const updated = await client.updateDataFeed(dataFeedId, patch);
console.dir(updated);
} catch (err) {
console.log("Error occurred when updating data feed");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ dotenv.config();
import {
MetricsAdvisorKeyCredential,
MetricsAdvisorAdministrationClient,
GetCredentialEntityResponse,
DatasourceCredentialPatch,
SqlServerConnectionStringDatasourceCredential
GetDataSourceCredentialEntityResponse,
DataSourceCredentialPatch,
DataSourceSqlConnectionString
} from "@azure/ai-metrics-advisor";

export async function main() {
Expand All @@ -27,19 +27,19 @@ export async function main() {

const adminClient = new MetricsAdvisorAdministrationClient(endpoint, credential);

const created = await createDatasourceCredential(adminClient);
const created = await createDataSourceCredential(adminClient);
if (created.id) {
await getDatasourceCredential(adminClient, created.id);
await updateDatasourceCredential(adminClient, created.id);
await listDatasourceCredentials(adminClient);
await deleteDatasourceCredential(adminClient, created.id);
await getDataSourceCredential(adminClient, created.id);
await updateDataSourceCredential(adminClient, created.id);
await listDataSourceCredentials(adminClient);
await deleteDataSourceCredential(adminClient, created.id);
}
}

async function listDatasourceCredentials(client: MetricsAdvisorAdministrationClient) {
console.log("Listing Datasource credentials ...");
async function listDataSourceCredentials(client: MetricsAdvisorAdministrationClient) {
console.log("Listing DataSource credentials ...");
console.log(" using while loop");
const iter = client.listDatasourceCredential();
const iter = client.listDataSourceCredential();
let result = await iter.next();
while (!result.done) {
console.log(`id :${result.value.id}, name: ${result.value.name}`);
Expand All @@ -48,7 +48,7 @@ async function listDatasourceCredentials(client: MetricsAdvisorAdministrationCli

// second approach
console.log(" using for-await-of loop");
const iterator = client.listDatasourceCredential();
const iterator = client.listDataSourceCredential();
for await (const datasourceCredential of iterator) {
console.log(
`id :${datasourceCredential.id}, name: ${datasourceCredential.name}, type: ${datasourceCredential.type}`
Expand All @@ -57,7 +57,7 @@ async function listDatasourceCredentials(client: MetricsAdvisorAdministrationCli

// by pages
console.log(" by pages");
const pages = client.listDatasourceCredential().byPage({ maxPageSize: 1 });
const pages = client.listDataSourceCredential().byPage({ maxPageSize: 1 });
let page = await pages.next();
let i = 1;
while (!page.done) {
Expand All @@ -71,34 +71,34 @@ async function listDatasourceCredentials(client: MetricsAdvisorAdministrationCli
}
}

async function createDatasourceCredential(
async function createDataSourceCredential(
client: MetricsAdvisorAdministrationClient
): Promise<GetCredentialEntityResponse> {
console.log("Creating Datasource credential...");
const datasourceCredential: SqlServerConnectionStringDatasourceCredential = {
): Promise<GetDataSourceCredentialEntityResponse> {
console.log("Creating DataSource credential...");
const datasourceCredential: DataSourceSqlConnectionString = {
name: "Sql-server-cred",
description: "an example sql server credential",
type: "AzureSQLConnectionString",
connectionString: "connection-string"
};
const result = await client.createDatasourceCredential(datasourceCredential);
const result = await client.createDataSourceCredential(datasourceCredential);
console.dir(result);
return result;
}

async function getDatasourceCredential(
async function getDataSourceCredential(
client: MetricsAdvisorAdministrationClient,
datasourceCredentialId: string
) {
console.log("Retrieving datasourceCredential by id...");
const result = await client.getDatasourceCredential(datasourceCredentialId);
const result = await client.getDataSourceCredential(datasourceCredentialId);
console.log("datasource credential result is as follows - ");
console.log(` id: ${result.id}`);
console.log(` datasource credential type: ${result.type}`);
console.log(` name: ${result.name}`);
}

async function updateDatasourceCredential(
async function updateDataSourceCredential(
client: MetricsAdvisorAdministrationClient,
credentialId: string
) {
Expand All @@ -107,25 +107,24 @@ async function updateDatasourceCredential(
description: "updated-description",
type: "AzureSQLConnectionString",
connectionString: "connection-string"
} as DatasourceCredentialPatch;
} as DataSourceCredentialPatch;

try {
console.log(`Updating credential ${credentialId}...`);
await client.updateDatasourceCredential(credentialId, patch);
const updated = await client.getDataFeed(credentialId);
const updated = await client.updateDataSourceCredential(credentialId, patch);
console.dir(updated);
} catch (err) {
console.log("Error occurred when updating credential");
console.log(err);
}
}

async function deleteDatasourceCredential(
async function deleteDataSourceCredential(
client: MetricsAdvisorAdministrationClient,
credentialId: string
) {
console.log(`Deleting datasource credential ${credentialId}...`);
await client.deleteDatasourceCredential(credentialId);
await client.deleteDataSourceCredential(credentialId);
}

main()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,7 @@ async function updateDetectionConfig(
]
};
console.log(`Updating existing detection configuration '${configId}'`);
await adminClient.updateDetectionConfig(configId, patch);
const result = adminClient.getDetectionConfig(configId);
const result = await adminClient.updateDetectionConfig(configId, patch);
console.log(result);
return result;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,7 @@ async function updateEmailHook(client: MetricsAdvisorAdministrationClient, hookI
toList: ["[email protected]", "[email protected]"]
}
};
await client.updateHook(hookId, emailPatch);
const response = await client.getHook(hookId);
const response = await client.updateHook(hookId, emailPatch);
console.log(response);
return response;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ async function provideAnomalyFeedback(client: MetricsAdvisorClient, metricId: st
value: "NotAnomaly",
dimensionKey: { city: "Manila", category: "Handmade" }
};
return await client.createFeedback(anomalyFeedback);
return await client.addFeedback(anomalyFeedback);
}

async function providePeriodFeedback(client: MetricsAdvisorClient, metricId: string) {
Expand All @@ -60,7 +60,7 @@ async function providePeriodFeedback(client: MetricsAdvisorClient, metricId: str
periodValue: 4,
dimensionKey: { city: "Manila", category: "Handmade" }
};
return await client.createFeedback(periodFeedback);
return await client.addFeedback(periodFeedback);
}

async function provideChangePointFeedback(client: MetricsAdvisorClient, metricId: string) {
Expand All @@ -72,7 +72,7 @@ async function provideChangePointFeedback(client: MetricsAdvisorClient, metricId
value: "ChangePoint",
dimensionKey: { city: "Manila", category: "Handmade" }
};
return await client.createFeedback(changePointFeedback);
return await client.addFeedback(changePointFeedback);
}

async function provideCommentFeedback(client: MetricsAdvisorClient, metricId: string) {
Expand All @@ -83,7 +83,7 @@ async function provideCommentFeedback(client: MetricsAdvisorClient, metricId: st
dimensionKey: { city: "Manila", category: "Handmade" },
comment: "This is a comment"
};
return await client.createFeedback(commendFeedback);
return await client.addFeedback(commendFeedback);
}

async function getFeedback(client: MetricsAdvisorClient, feedbackId: string) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ async function getEnrichedSeriesData(client: MetricsAdvisorClient, detectionConf
try {
const result = await client.getMetricEnrichedSeriesData(
detectionConfigId,
new Date("09/01/2020"),
new Date("09/12/2020"),
[
{ city: "Manila", category: "Handmade" },
{ city: "Shanghai", category: "Shoes Handbags & Sunglasses" }
]
],
new Date("09/01/2020"),
new Date("09/12/2020")
);

for (const enriched of result) {
Expand Down Expand Up @@ -71,12 +71,12 @@ async function getMetricSeriesData(client: MetricsAdvisorClient, metricId: strin
try {
const result = await client.getMetricSeriesData(
metricId,
new Date("09/01/2020"),
new Date("09/12/2020"),
[
{ city: "Manila", category: "Handmade" },
{ city: "Shanghai", category: "Shoes Handbags & Sunglasses" }
]
],
new Date("09/01/2020"),
new Date("09/12/2020")
);

for (const series of result) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,7 @@ async function updateAlertConfig(adminClient, alertConfigId, detectionConfigId,
]
};
console.log(`Updating alerting configuration ${detectionConfigId}`);
await adminClient.updateAlertConfig(alertConfigId, patch);
const updated = await adminClient.getAlertConfig(alertConfigId);
const updated = await adminClient.updateAlertConfig(alertConfigId, patch);
return updated;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,7 @@ async function updateDataFeed(client, dataFeedId) {

try {
console.log(`Updating datafeed ${dataFeedId}...`);
await client.updateDataFeed(dataFeedId, patch);
const updated = await client.getDataFeed(dataFeedId);
const updated = await client.updateDataFeed(dataFeedId, patch);
console.dir(updated);
} catch (err) {
console.log("Error occurred when updating data feed");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ async function updateDatasourceCredential(client, credentialId) {

try {
console.log(`Updating credential ${credentialId}...`);
await client.updateDatasourceCredential(credentialId, patch);
const updated = await client.getDataFeed(credentialId);
const updated = await client.updateDatasourceCredential(credentialId, patch);
console.dir(updated);
} catch (err) {
console.log("Error occurred when updating credential");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,7 @@ async function updateDetectionConfig(adminClient, configId) {
]
};
console.log(`Updating existing detection configuration '${configId}'`);
await adminClient.updateDetectionConfig(configId, patch);
const result = adminClient.getDetectionConfig(configId);
const result = await adminClient.updateDetectionConfig(configId, patch);
console.log(result);
return result;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ async function updateEmailHook(client, hookId) {
toList: ["[email protected]", "[email protected]"]
}
};
await client.updateHook(hookId, emailPatch);
const response = await client.getHook(hookId);
const response = await client.updateHook(hookId, emailPatch);
console.log(response);
return response;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ async function provideAnomalyFeedback(client, metricId) {
value: "NotAnomaly",
dimensionKey: { city: "Manila", category: "Handmade" }
};
return await client.createFeedback(anomalyFeedback);
return await client.addFeedback(anomalyFeedback);
}

async function providePeriodFeedback(client, metricId) {
Expand All @@ -52,7 +52,7 @@ async function providePeriodFeedback(client, metricId) {
periodValue: 4,
dimensionKey: { city: "Manila", category: "Handmade" }
};
return await client.createFeedback(periodFeedback);
return await client.addFeedback(periodFeedback);
}

async function provideChangePointFeedback(client, metricId) {
Expand All @@ -64,7 +64,7 @@ async function provideChangePointFeedback(client, metricId) {
value: "ChangePoint",
dimensionKey: { city: "Manila", category: "Handmade" }
};
return await client.createFeedback(changePointFeedback);
return await client.addFeedback(changePointFeedback);
}

async function provideCommentFeedback(client, metricId) {
Expand All @@ -75,7 +75,7 @@ async function provideCommentFeedback(client, metricId) {
dimensionKey: { city: "Manila", category: "Handmade" },
comment: "This is a comment"
};
return await client.createFeedback(commendFeedback);
return await client.addFeedback(commendFeedback);
}

async function getFeedback(client, feedbackId) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/metricsadvisor/ai-metrics-advisor",
"dependencies": {
"@azure/ai-metrics-advisor": "next",
"@azure/ai-metrics-advisor": "latest",
"dotenv": "latest"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
METRICS_ADVISOR_ENDPOINT=https://<resource name>.cognitiveservices.azure.com/
METRICS_ADVISOR_SUBSCRIPTION_KEY=<subscription key>
METRICS_ADVISOR_API_KEY=<api key>
# METRICS_ADVISOR_METRIC_ID=
# METRICS_ADVISOR_DETECTION_CONFIG_ID=
# METRICS_ADVISOR_HOOK_ID=
# METRICS_ADVISOR_DATAFEED_ID=
# METRICS_ADVISOR_INCIDENT_ID=
# METRICS_ADVISOR_SQL_SERVER_CONNECTION_STRING=
# METRICS_ADVISOR_AZURE_SQL_SERVER_QUERY=

# Our tests assume that TEST_MODE is "playback" by default. You can
# change it to "record" to generate new recordings, or "live" to bypass the recorder entirely.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ async function getEnrichedSeriesData(client, detectionConfigId) {
try {
const result = await client.getMetricEnrichedSeriesData(
detectionConfigId,
new Date("09/01/2020"),
new Date("09/12/2020"),
[
{ city: "Manila", category: "Handmade" },
{ city: "Shanghai", category: "Shoes Handbags & Sunglasses" }
]
],
new Date("09/01/2020"),
new Date("09/12/2020")
);

for (const enriched of result) {
Expand Down Expand Up @@ -70,12 +70,12 @@ async function getMetricSeriesData(client, metricId) {
try {
const result = await client.getMetricSeriesData(
metricId,
new Date("09/01/2020"),
new Date("09/12/2020"),
[
{ city: "Manila", category: "Handmade" },
{ city: "Shanghai", category: "Shoes Handbags & Sunglasses" }
]
],
new Date("09/01/2020"),
new Date("09/12/2020")
);

for (const series of result) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/metricsadvisor/ai-metrics-advisor",
"dependencies": {
"@azure/ai-metrics-advisor": "next",
"@azure/ai-metrics-advisor": "latest",
"dotenv": "latest"
},
"devDependencies": {
Expand Down
Loading