Merged
Conversation
chidozieononiwu
requested review from
danieljurek,
deyaaeldeen,
mikeharder,
mitchdenny,
praveenkuttappan,
weshaggard and
witemple-msft
as code owners
weshaggard
reviewed
Jun 22, 2021
Member
There was a problem hiding this comment.
Can you check where we use this? It is sort of a different pattern then other repos and if we don't use it I would suggest removing it.
Member
Author
There was a problem hiding this comment.
I believe it is being used here
Member
There was a problem hiding this comment.
I think that is coming the matrix but I could be wrong.
Member
There was a problem hiding this comment.
In any case it doesn't necessarily hurt to have it but we don't need it we should remove it.
chidozieononiwu
force-pushed
the
UpdateUbubtuVMImage
branch
from
17ee02f to
713a613
Compare
weshaggard
reviewed
Jun 23, 2021
|
|
||
| pool: | ||
| vmImage: 'Ubuntu 16.04' | ||
| vmImage: 'Ubuntu 20.04' |
Member
There was a problem hiding this comment.
We might need to ask the mgmt team about this change.
weshaggard
approved these changes
Jun 23, 2021
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Please verify some test pipelines and a mgmt pipeline to ensure they still work.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Aug 20, 2021
track2 modify automation readme.go.md (Azure#15706)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to