Skip to content

Fix some duplicated url fragments to unblock sample publication.#15453

Merged
2 commits merged intoAzure:masterfrom
witemple-msft:fix-samples-again-and-again
May 29, 2021
Merged

Fix some duplicated url fragments to unblock sample publication.#15453
2 commits merged intoAzure:masterfrom
witemple-msft:fix-samples-again-and-again

Conversation

@witemple-msft
Copy link
Member

We forgot to remove the old samples from keyvault-secrets after merging in the new ones under samples/v4.

@witemple-msft witemple-msft requested a review from sadasant May 27, 2021 23:01
@ghost ghost added the KeyVault label May 27, 2021
@witemple-msft
Copy link
Member Author

/azp run js - keyvault-secrets - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s go!

@sadasant
Copy link
Contributor

Hmm why did this break? I’d like to understand 🤔

@sadasant
Copy link
Contributor

I’ll re-run the build just in case.

Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thanks @witemple-msft 😍

@witemple-msft
Copy link
Member Author

/azp run js - keyvault-secrets - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented May 28, 2021

Hello @witemple-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit f77c218 into Azure:master May 29, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants