Automate docs.ms CI onboarding with docindex #15400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljurek
requested review from
mikeharder,
mitchdenny,
praveenkuttappan and
weshaggard
as code owners
Member
Author
|
@weshaggard -- PTAL |
weshaggard
reviewed
May 25, 2021
weshaggard
reviewed
May 25, 2021
weshaggard
reviewed
May 25, 2021
weshaggard
reviewed
May 25, 2021
weshaggard
reviewed
May 25, 2021
weshaggard
reviewed
May 25, 2021
weshaggard
reviewed
May 25, 2021
weshaggard
reviewed
May 25, 2021
weshaggard
reviewed
May 25, 2021
danieljurek
force-pushed
the
djurek/docs-ci-onboarding
branch
from
fba6e53 to
ed92076
Compare
weshaggard
reviewed
May 26, 2021
weshaggard
reviewed
May 26, 2021
weshaggard
reviewed
May 26, 2021
weshaggard
reviewed
May 26, 2021
weshaggard
approved these changes
May 26, 2021
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
I left a few minor comments but I do like this version a lot better. It is more in line with what I was looking for originally where the core of the logic can be applied twice once for preview and once for ga. Nice job.
weshaggard
reviewed
May 26, 2021
weshaggard
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=910706&view=results
Note that this updates package versions and handles supersedence -- MicrosoftDocs/azure-docs-sdk-node@4676796
eng/common changes -- Azure/azure-sdk-tools#1635