Skip to content

Update README.md for arm-consumption#15382

Closed
bobalong79 wants to merge 1 commit intoAzure:mainfrom
Liverpool-Victoria:fix/arm-consumption-readme
Closed

Update README.md for arm-consumption#15382
bobalong79 wants to merge 1 commit intoAzure:mainfrom
Liverpool-Victoria:fix/arm-consumption-readme

Conversation

@bobalong79
Copy link
Copy Markdown

Fixed incorrect code in readme to account for new interface

Fixed incorrect code in readme to account for new interface
@bobalong79 bobalong79 requested a review from qiaozha as a code owner May 24, 2021 09:58
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 24, 2021
@ghost
Copy link
Copy Markdown

ghost commented May 24, 2021

Thank you for your contribution bobalong79! We will review the pull request and get back to you soon.

@ramya-rao-a
Copy link
Copy Markdown
Contributor

Thanks for the PR @bobalong79

@deyaaeldeen Any idea why the generated code is buggy here? Shouldnt we be showing the list() case without any parameters?

@ramya-rao-a
Copy link
Copy Markdown
Contributor

@bobalong79 Looks like there are merge conflicts on this PR. Can you resolve them please?

@qiaozha Generally, we avoid hand written changes on auto generated packages. In this case, I would say that we should take the fix and then log an issue in the code gen repo.

@qiaozha
Copy link
Copy Markdown
Member

qiaozha commented Sep 3, 2021

we haven't onboard track2 for arm-consumption packages yet. we are using feature/v4 branch for all track1 sdk releases now. Any changes for track1 should be targeting at feature/v4 branch. @bobalong79 Could you please close this PR and open another one targeting at feature/v4 branch ? Thanks

@ramya-rao-a
Copy link
Copy Markdown
Contributor

@qiaozha Looks like we may not get a response from @bobalong79 soon. Can you create a new PR to the feature/v4 branch and close this one?

@qiaozha
Copy link
Copy Markdown
Member

qiaozha commented Sep 17, 2021

close it as #17726 has been merged. Thanks

@qiaozha qiaozha closed this Sep 17, 2021
@bobalong79 bobalong79 deleted the fix/arm-consumption-readme branch October 23, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants