[storage-blob][storage-file-datalake]Deprecate destination...Name in the restore operations.#15265
Merged
EmmaZhu merged 1 commit intoAzure:masterfrom May 14, 2021
Merged
Conversation
EmmaZhu
requested review from
HarshaNalluru,
XiaoningLiu,
jeremymeng,
jiacfan,
ljian3377 and
vinjiang
as code owners
ghost
added
the
xirzec
approved these changes
May 13, 2021
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
This is the approach we've been using in other libraries. The idea is we mark things as @deprecated first and then remove them entirely in the next major release.
jeremymeng
approved these changes
May 13, 2021
Contributor
There was a problem hiding this comment.
Mention in the changelog as well?
Contributor
There was a problem hiding this comment.
Looks like the CI is failing because of mismatch in the API report.. please do rushx build and push changes!
EmmaZhu
force-pushed
the
undeletecontainer0
branch
from
517a0eb to
757249c
Compare
EmmaZhu
force-pushed
the
undeletecontainer0
branch
from
757249c to
29d2929
Compare
…iner Deprecate destinationFileSystemName in DataLakeServiceClient.undeleteFileSystem
EmmaZhu
force-pushed
the
undeletecontainer0
branch
from
29d2929 to
836f681
Compare
HarshaNalluru
approved these changes
May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate destinationContainerName in BlobServiceClient.undeleteContainer
Deprecate destinationFileSystemName in DataLakeServiceClient.undeleteFileSystem