Purview Scanning Rest Client#14918
Purview Scanning Rest Client#14918joheredi merged 20 commits intoAzure:masterfrom joheredi:purview-scanning
Conversation
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
deyaaeldeen
left a comment
There was a problem hiding this comment.
LGTM but I think the readme needs some love
There was a problem hiding this comment.
Is emitting factories a new feature in llc code gen?
There was a problem hiding this comment.
yes a new thing for LLCs 😄 we are basing our new clients in functions and objects, no classes so far.
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
seems like we need more hero scenarios than just listing, since I imagine you'd want to show scanning, etc
There was a problem hiding this comment.
I believe that the service team will assist us with writing some sample additional samples
New REST package for Azure Purview Scanning. @azure-rest/purview-scanning