Remove and ignore tsdoc-metadata.json#14681
Merged
xirzec merged 1 commit intoAzure:masterfrom Apr 2, 2021
Merged
Conversation
witemple-msft
added
EngSys
witemple-msft
requested review from
bterlson,
chradek,
jeremymeng and
xirzec
as code owners
xirzec
approved these changes
Apr 2, 2021
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
This was bothering me! Thanks so much for fixing! 👍
humphd
added a commit
to humphd/azure-sdk-for-js
that referenced
this pull request
Sep 23, 2021
HarshaNalluru
pushed a commit
that referenced
this pull request
Sep 23, 2021
…pts (#17820) * Add tsdoc-metadata.json to .prettierignore for @azure/core-rest-pipeline failure, see #14681 * Fix paths to .prettierrc.json and .prettierignore in @azure-tools/perf-container-registery package.json * Run prettier with prettierrc.json config on sdk/test-utils/testing-recorder-new/rollup.base.config.js * Use global prettier config and ignore for identity/identity/test/manual * Use global prettier config and ignore in common/tools/eslint-plugin-azure-sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsdoc-metadata.json, as explained in #8662, isn't something we want, and its comments describe it as something we shouldn't check in. This PR removes the one instance of it being checked in in core-rest-pipeline and adds it to.gitignore. Hopefully we can move to a newer AE version that will just eliminate this problem entirely, but for now we can just ignore it.This should keep us from having to look at this file in our untracked changes whenever it's generated.