[core-rest-pipeline] WWW-Authenticate challenge perf-stress test#14659
Merged
9 commits merged intoAzure:masterfrom May 3, 2021
Merged
[core-rest-pipeline] WWW-Authenticate challenge perf-stress test#146599 commits merged intoAzure:masterfrom
9 commits merged intoAzure:masterfrom
Conversation
jeremymeng
reviewed
Apr 30, 2021
Member
jeremymeng
left a comment
There was a problem hiding this comment.
Looks good to me. /cc @HarshaNalluru for perf-test perspective.
| } | ||
| ]; | ||
|
|
||
| const expiresOn = Date.now() + 5000; |
Contributor
There was a problem hiding this comment.
Can the 5000 be parametrized? Is there value in doing it?
Contributor
Author
There was a problem hiding this comment.
No value in doing it at the moment, I think 🤔
jeremymeng
approved these changes
May 3, 2021
|
Hello @sadasant! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a draft of how the WWW-Authenticate perf-stress would look.
What this first performance test does:
This initial test only sets up a pipeline that does a service request against a fake server that answers once with a WWW-Authenticate challenge, and the next time with a 200. So, the first request will fail, we'll get a challenge, the challenge will be parsed and another request will be sent afterwards, which will succeed.
To run the test, we call to:
npm run perf-test:node -- BearerTokenChallengeAuthenticationPolicyTest --warmup 1 --iterations 1 --parallel 5.Here's how it looks when it runs:
Background:
Java's perf-stress for challenges uses the ARM kind of challenges, but on TypeScript our more immediate customer is not ARM, but Container Registry and then Key Vault.
This PR uses a copy of the challenge test we have in the main challenge PR: #13888 (this PR hasn't been merged, the plan is to have it merged by next week). Keep in mind that this PR won't pass CI until #13888 is merged.
The idea with this PR is that, besides perf-stress testing a basic scenario, we can use it as the base for further perf-stress tests for core-rest-pipeline.
Fixes #14633