[dev-tool] Fix relative import of prettier options.#14560
Merged
witemple-msft merged 1 commit intoAzure:masterfrom Mar 26, 2021
Merged
[dev-tool] Fix relative import of prettier options.#14560witemple-msft merged 1 commit intoAzure:masterfrom
witemple-msft merged 1 commit intoAzure:masterfrom
Conversation
witemple-msft
requested review from
mikeharder and
praveenkuttappan
as code owners
deyaaeldeen
approved these changes
Mar 26, 2021
Member
deyaaeldeen
left a comment
deyaaeldeen
left a comment
There was a problem hiding this comment.
I had a hunch my change would not work because require is dynamically called and indeed this is the case. Thanks for the fix! Please consider adding integration tests in this PR or in another.
Member
Author
|
Going to add a few tests for this in a different PR. Merging this to unblock |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jul 29, 2021
Exposing reviewers property on accessReviewInstance model (Azure#14560) * Cloning version 2021-07-01-preview from version 2021-03-01-preview * Exposing reviewers properties on accessReviewInstance model * Fixing SDK validation warnings * Prettier check fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import path isn't quite correct and
ts-to-jsthrows.