Skip to content

Make tag as optional#14427

Merged
praveenkuttappan merged 2 commits intoAzure:masterfrom
praveenkuttappan:support_empty_tags
Mar 26, 2021
Merged

Make tag as optional#14427
praveenkuttappan merged 2 commits intoAzure:masterfrom
praveenkuttappan:support_empty_tags

Conversation

@praveenkuttappan
Copy link
Copy Markdown
Member

tag is not optional now to publish a package to npm. This causes an issue when a hotfix package is required to be released. So this version get released as latest and then manually needs to adjust the tag to flip it back to actual latest version. This PR is to support publishing package to npm without any tag. I have another issue in backlog to support setting latest and next tag automatically. This issue will be taken care separately.

@praveenkuttappan praveenkuttappan self-assigned this Mar 23, 2021
@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Mar 23, 2021
@praveenkuttappan
Copy link
Copy Markdown
Member Author

Verified using @azure/template release pipeline to publish version 1.0.9-beta.798246 without changing tag:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=798246&view=logs&j=8a59aa26-f1cb-5dea-999b-76ab4b63e138&t=3aff0b02-11c2-52e1-59c8-fe61f5396ef2

Copy link
Copy Markdown
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks reasonable.

@praveenkuttappan
Copy link
Copy Markdown
Member Author

@praveenkuttappan praveenkuttappan merged commit 74a6162 into Azure:master Mar 26, 2021
mikeharder added a commit to mikeharder/azure-sdk-for-js that referenced this pull request Apr 6, 2021
mikeharder added a commit that referenced this pull request Apr 7, 2021
- #14427 appears to cause all packages to be published with no tags.
- This reverts commit 74a6162.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants