[KeyVault] - Replace keyId: URL with certificateKeyId: string

[maorleger]

what

• Deprecate secretProperties.keyId and replace it with secretProperties.certificateKeyId
• Remove dom from tsconfig

why

secretProperties.keyId being a URL is the only reason we need dom lib in this library.
Even though it has never been populated we cannot remove it because we might break
someone's compilation (although it would have never worked at runtime).

Instead we'll deprecate it, note that it will always be undefined, and make it an any so
we can remove the dependency on dom.

Refer to #9639 for previous work in this area.

Resolves #10726

[sadasant]

I love it! Thank you so much 🌞

[maorleger]

@bterlson / @xirzec - mind giving this a quick look when you have a second? I want to make sure this isn't harmful (or if it is, if there's a better way to handle it - any vs unknown or something else). Context here is: we had a property keyId?: URL which is the only reason we needed to pull in dom but it was never actually populated at runtime.

We can't remove the field entirely to avoid breaking compilation (see #9639) so we deprecate it, make it unknown, and introduce a better named field that's a string instead (also taken from feedback on #9639). Then we can remove dom as a dependency?

[xirzec]

I'm a fan of this approach. We should start using deprecation more to signal when things are going to move in the next major.

[ramya-rao-a]

Nit: Some may take the "this" here to refer to certificateKeyId :)

How about the below?

The keyId field has and will be left as undefined.