[telemetry] Centralize (as much as is practical) the creation of spans to ease upgrades#13887
Merged
richardpark-msft merged 55 commits intoAzure:masterfrom Feb 26, 2021
Merged
Conversation
…ed for core-tracing to compile and test
…ich will shortly have a new OT)
…s a bit more complicated)
richardpark-msft
requested review from
EmmaZhu,
HarshaNalluru,
KarishmaGhiya,
XiaoningLiu,
bterlson,
chradek,
daviwil,
deyaaeldeen,
ellismg,
jeremymeng,
jiacfan,
joheredi,
ljian3377,
maorleger,
ramya-rao-a,
sadasant,
sarangan12,
schaabs,
sophiajt,
vinjiang,
witemple-msft and
xirzec
as code owners
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run js - storage-queue - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run js - storage-file-share - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run js - storage-queue - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sadasant
reviewed
Feb 24, 2021
sadasant
reviewed
Feb 24, 2021
sadasant
reviewed
Feb 24, 2021
sadasant
reviewed
Feb 24, 2021
sadasant
reviewed
Feb 24, 2021
sadasant
reviewed
Feb 24, 2021
sadasant
reviewed
Feb 24, 2021
sdk/identity/identity/src/credentials/managedIdentityCredential/imdsMsi.ts
Show resolved
Hide resolved
sadasant
reviewed
Feb 24, 2021
sdk/identity/identity/src/credentials/managedIdentityCredential/index.ts
Show resolved
Hide resolved
sadasant
reviewed
Feb 24, 2021
sadasant
reviewed
Feb 24, 2021
Contributor
sadasant
left a comment
sadasant
left a comment
There was a problem hiding this comment.
For identity this looks good!
chradek
reviewed
Feb 25, 2021
| parent: span.context(), | ||
| attributes: { | ||
| ...spanOptions.attributes, | ||
| "az.namespace": args.namespace |
Contributor
There was a problem hiding this comment.
If we moved this to the original spanOptions, would we need to call span.setAttribute on our span object?
Member
Author
There was a problem hiding this comment.
I'd have to try that out (I reserve that for another PR) but that makes logical sense to me. I moved this code so there might be some subtle behavior that I'm not aware of.
HarshaNalluru
approved these changes
Feb 25, 2021
Member
Author
|
Thank you all for your help reviewing! :) |
Member
|
/azp run js - keyvault - ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opentelemetry package recently removed a field we were all using to propagate spans (.parent). This ends up breaking an unreasonable number of places because we have multiple copies of the 'createSpan' function in the codebase.
We already had a pretty solid version that would generate a personalized createSpan function for you so I moved that into azure/core-tracing and have changed everyone to call it instead.
For the most part this should be pretty straightforward to review. Apart from centralizing the createSpan calls (and moving code into core-tracing) I've made no code changes.