rush update --full

[xirzec]

#13353 once again re-introduced karma-remap-instanbul into our lockfile, perhaps due to bad merge from master. This PR hopefully will resolve this for the last time.

[ghost]

Hello @xirzec!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[HarshaNalluru]

Is this supposed to go down?

[xirzec]

My understanding was this was bumped up accidentally by this PR: 189bb99#diff-5029779360a5dab7df00ff76c5693ce33b68f76d2f433b44a28b333bf33f674a

/cc @ramya-rao-a @jonathandturner

[xirzec]

It was fixed in a previous commit I did too: 24cbc28#diff-5029779360a5dab7df00ff76c5693ce33b68f76d2f433b44a28b333bf33f674a

Looks like we've had a spate of folks not reverting the lockfile to master before running rush update when there's a conflict?

[ramya-rao-a]

cc @deyaaeldeen

[deyaaeldeen]

I think the following two observations might have to do with this:

• The dependencies for @types packages are typically other @types packages with the semvar being just "*". For example, if you look at common/temp/node_modules/@types/fs-extra/package.json, you will see the following:

 "dependencies": {
        "@types/node": "*"
    }

this introduces issues such as microsoft/rushstack#750.

• rush uses pnpm's fewer-deps strategy by default as indicated here: https://github.com/microsoft/rushstack/blob/9d175a4401545b437869d33a2a67c29042ceeb97/apps/rush-lib/src/api/RushConfiguration.ts#L374 and we explicitly use that strategy here:

  azure-sdk-for-js/rush.json

  Line 54 in b873932

  "resolutionStrategy": "fewer-dependencies"

  . If I understand correctly, this means pnpm will work hard to use the fewest number of packages possible to satisfy the constraints.

[ramya-rao-a]

cc @sarangan12

@xirzec, What could we have done to prevent the regression?

[xirzec]

@xirzec, What could we have done to prevent the regression?

I gotta figure out if rush is just not doing the right thing, or if I can document a process for handling pnpm-lockfile conflicts that will work for everyone.