[DEBUG] Flaky test - Batch receiver disconnect - 100 iterations#13339
Closed
HarshaNalluru wants to merge 11 commits intoAzure:masterfrom
Closed
[DEBUG] Flaky test - Batch receiver disconnect - 100 iterations#13339HarshaNalluru wants to merge 11 commits intoAzure:masterfrom
HarshaNalluru wants to merge 11 commits intoAzure:masterfrom
Conversation
ghost
added
the
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
HarshaNalluru
changed the title
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 tasks
Contributor
Author
|
#13374 closes this |
ghost
pushed a commit
that referenced
this pull request
Jan 26, 2021
## Bug - `receiveMessages` method returned zero messages upon a connection refresh caused by a network disconnect(simulated in the test). - `OperationTimeout` error on message settlement after the disconnect These two failures made the "disconnect" test occasionally fail for the batching receiver. ## Cause `onDetached` on the batchReceivers is called 300ms after the connection refresh causing the recovered receive link to be closed. - If the message returned from the service took close to 300ms until reached the receiver since the refresh, `onDetached` is called to close the link leading to the loss of messages. - If the 300ms had elapsed right before the settlement, we'd see the OperationTimeout error on settlement since the receive link is closed. Investigated here #13339 ## Fix - Call `onDetached` for the batching receivers before calling the refresh connection - And retain calling `onDetached` for the streaming receivers after the refresh connection ## Changes in the PR - [x] Refactored "calling onDetached" part - [x] Removed the 300ms delay since we don't see the utility - [x] Changelog - [x] TODO: What to do for sessions? - [x] Needs more investigation #13374 (comment), will be handled at #8875
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.